fix: update runtime check for min google-cloud-bigquery to 3.3.5 #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
The minimum version of google-cloud-bigquery was updated to 3.3.5 in pandas-gbq version 0.18.0 (released November 2022). This change updates the runtime check in features.py to reflect that minimum version and removes some dead code for feature checks that are no longer relevant.
tswast force-pushed the tswast-dead-feature-comparison-code branch from b309634 to 83643a8 Compare 4 tasks
Linchin approved these changes Jan 13, 2024
Contributor
Linchin left a comment
Linchin left a comment There was a problem hiding this comment.
Thank you! All looks good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The minimum version of google-cloud-bigquery was updated to 3.3.5 in pandas-gbq
version 0.18.0 (released November 2022). This change updates the runtime check
in features.py to reflect that minimum version and removes some dead code for
feature checks that are no longer relevant.
Please review #720 first.Edit: removed conflicting setup.py change so these changes are now independent.🦕