fix: gracefully ignore RejectedExecutionException during Connection#close() #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
olavloite commented May 24, 2022
| abortBatch(); | ||
| } | ||
| if (isTransactionStarted()) { | ||
| synchronized (this) { |
There was a problem hiding this comment.
This change looks bigger than it is. The actual change here is that:
- The block is placed inside a
synchronized (this)block. - The
futures.add(statementExecutor.submit(() -> null));line is placed inside a try-catch block.
gcf-merge-on-green bot pushed a commit that referenced this pull request May 31, 2022
🤖 I have created a release *beep* *boop* --- ## [6.25.5](v6.25.4...v6.25.5) (2022-05-31) ### Bug Fixes * add configurations for Explain feature ([#1899](#1899)) ([86895b7](86895b7)) * gracefully ignore RejectedExecutionException during Connection#close() ([#1887](#1887)) ([091bd1d](091bd1d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Gracefully catch and ignore
RejectedExecutionExceptions that might happen while closing a connection. This prevents theSpannerPoolfrom holding on to connections that failed to close because of such an error.