Skip to content

docs(sample): use Java 8 for native image sample #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

docs(sample): use Java 8 for native image sample #1060

merged 1 commit into from
Mar 18, 2022

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 18, 2022

The native image sample is failing during the nightly build with the following error:

ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] javac: invalid target release: 11 Usage: javac <options> <source files> use -help for a list of possible options

This is because the Kokoro job uses Java 8. Setting the compiler Java version of the sample to Java 8 should be able to address this issue.
@mpeddada1 mpeddada1 requested a review from anguillanneuf March 18, 2022 17:45
@mpeddada1 mpeddada1 requested review from a team as code owners March 18, 2022 17:45
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Mar 18, 2022
anguillanneuf
anguillanneuf approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@mpeddada1 mpeddada1 merged commit 2d5c010 into main Mar 18, 2022
@mpeddada1 mpeddada1 deleted the native-sample branch March 18, 2022 18:48
@release-please release-please bot mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples.

4 participants

@mpeddada1 @anguillanneuf @averikitsch