Skip to content

Conversation

risnayak
Copy link
Contributor

@risnayak risnayak commented Jan 30, 2023

We allow users to set a missing value map for the StreamWriter and JsonStreamWriter. The value of the missing value map will be re-used by the writer till changed otherwise.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@risnayak risnayak requested review from a team and yirutang January 30, 2023 01:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jan 30, 2023
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@risnayak
Copy link
Contributor Author

Looks good, could you add a e2e test to make sure it works? https://github.com/googleapis/java-bigquerystorage/blob/main/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryWriteManualClientTest.java

Yep I can definitely add E2E tests! The only thing issue is we'd first need #1988 to be submitted, and then we can add E2E tests (since we won't be able to create tables with default values without this).

If it sounds ok, I can add the E2E test in a followup request.

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 21, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 21, 2023
@yirutang yirutang merged commit 98d7e44 into googleapis:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.

3 participants