feat: add remote function options to routine metadata #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Warning: This pull request is touching the following templated files:
|
product-auto-label bot added the api: bigquery 
Neenu1995 added kokoro:force-run 
gcf-owl-bot bot removed the owlbot:run 
yoshi-kokoro removed the kokoro:force-run Neenu1995 added kokoro:force-run gcf-owl-bot bot removed the owlbot:run 
Contributor Author
| @shollyman @alvarowolfx PTAL |
alvarowolfx reviewed Sep 26, 2022
| RoutineInfo routineInfo = | ||
| RoutineInfo.newBuilder(routineId) | ||
| .setRoutineType("SCALAR_FUNCTION") | ||
| .setBody("x * 3") |
There was a problem hiding this comment.
I think the body and language are not needed in the context of a remote function.
Neenu1995 added kokoro:force-run yoshi-kokoro removed the kokoro:force-run Neenu1995 added the automerge 
gcf-merge-on-green bot removed the automerge 
This was referenced Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.