Skip to content

Conversation

tristan-lin
Copy link
Contributor

We have a limit of batch request which is defined in the doc[1].
However, in the batch class there is no such limit, which usually result
a timeout somewhere and very hard to debug.

[1] https://developers.google.com/api-client-library/python/guide/batch

However, in the batch class there is no such limit, which usually result a timeout somewhere and very hard to debug. [1] https://developers.google.com/api-client-library/python/guide/batch
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
linxinan-chops and others added 2 commits November 9, 2018 22:50
We have a limit of batch request which is defined in the doc[1]. However, in the batch class there is no such limit, which usually results a timeout somewhere else and hard to debug. [1] https://developers.google.com/api-client-library/python/guide/batch
@tristan-lin tristan-lin changed the title Add a limit for the size of batch request Add a limit for the batch request Nov 9, 2018
@theacodes
Copy link
Contributor

Please add a corresponding test for this.

Copy link

@vianney-g vianney-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I faced the same debug enigma.

@tristan-lin
Copy link
Contributor Author

@theacodes thanks! I will add a test to this PR shortly.

@tristan-lin
Copy link
Contributor Author

Done :)

Co-Authored-By: tristan-lin <tristan-lin@users.noreply.github.com>
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 29, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 29, 2018

@theacodes, can you flip the CLA flag? @tristan-lin used my suggestion, which causes the bot to flag the commit.

@tristan-lin
Copy link
Contributor Author

@tseaver thanks for your approval!
@theacodes what else I could do to get the PR merged?

@theacodes theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 6, 2018
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@theacodes theacodes merged commit e2dccec into googleapis:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

6 participants