- Notifications
You must be signed in to change notification settings - Fork 2.5k
Add a limit for the batch request #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
However, in the batch class there is no such limit, which usually result a timeout somewhere and very hard to debug. [1] https://developers.google.com/api-client-library/python/guide/batch
We have a limit of batch request which is defined in the doc[1]. However, in the batch class there is no such limit, which usually results a timeout somewhere else and hard to debug. [1] https://developers.google.com/api-client-library/python/guide/batch
Please add a corresponding test for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I faced the same debug enigma.
@theacodes thanks! I will add a test to this PR shortly. |
Done :) |
Co-Authored-By: tristan-lin <tristan-lin@users.noreply.github.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googleapiclient/http.py.
@theacodes, can you flip the CLA flag? @tristan-lin used my suggestion, which causes the bot to flag the commit. |
@tseaver thanks for your approval! |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
We have a limit of batch request which is defined in the doc[1].
However, in the batch class there is no such limit, which usually result
a timeout somewhere and very hard to debug.
[1] https://developers.google.com/api-client-library/python/guide/batch