Skip to content

Conversation

thehesiod
Copy link
Contributor

resolves #494

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2018
@thehesiod thehesiod changed the title Thehesiod socket timeout fix socket.timeout retry Apr 23, 2018
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually like a separate branch for socket.timeout, e.g.:

try: ... except ...: except socket.timeout as socket_timeout: ... except socket.error as socket_error: ... ...

Also, would you mind adding a test to cover this case?

@thehesiod
Copy link
Contributor Author

ok updated, I think I can change the existing tests as there is no mention of TimeoutError being thrown for sockets, instead even for python2 socket.timeout is what it should be: https://docs.python.org/2/library/socket.html#socket.timeout

@theacodes
Copy link
Contributor

@thehesiod if you rebase, #496 should fix the test failure.

@theacodes theacodes merged commit fff3ae5 into googleapis:master Apr 27, 2018
@thehesiod thehesiod deleted the thehesiod-socket-timeout branch March 8, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants