Skip to content

Conversation

chrish42
Copy link
Contributor

Change the wording to explicitly mention that Python 3.3 and 3.4 are supported (instead of saying "3.3+"), as these are the versions that are tested in the tox.ini file.

Change the wording to explicitly mention that Python 3.3 and 3.4 are supported (instead of saying "3.3+"), as these are the versions that are tested in the tox.ini file.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 14, 2016
@chrish42
Copy link
Contributor Author

I signed the CLA.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 14, 2016
README.md Outdated
Python 2.6 or 2.7 are fully supported.

Python 3.3+ is also now supported! However, this library has not yet been used
Python 3.3 & 3.4 are also now supported! However, this library has not yet been used

This comment was marked as spam.

@theacodes theacodes merged commit 5dcd66c into googleapis:master Dec 14, 2016
@chrish42
Copy link
Contributor Author

Haha. Sure! I can even update the tox.ini file to test on 3.5 too, if you want. :-)

A bit more seriously, testing on 3.5 would be really nice, because it's much more interesting than 3.4 for both scientific computing (matrix multiply operator) and writing server software (async & await).

@theacodes
Copy link
Contributor

Thanks, @chrish42

@theacodes
Copy link
Contributor

I can even update the tox.ini file to test on 3.5 too, if you want. :-)

@chrish42 be my guest. It's been on my list but I've been busy with google-auth and haven't had time to circle back to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants