Add a warning when using mocking without cache. #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot added the cla: no 
| Signed. |
| CLAs look good, thanks! |
googlebot added cla: yes 
googleapiclient/discovery.py Outdated
| if isinstance(service, six.string_types): | ||
| service = json.loads(service) | ||
| | ||
| if not 'rootUrl' in service and (isinstance(http, HttpMock) or |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| Sorry to have missed that on first review. Please also squash commits and follow these guidelines in your commit message. |
If HttpMock or HttpMockSequence is used in a test without the cache being filled first, a strange KeyError will be thrown. This happens on e.g. Travis CI. Unfortunately this behavior is used in the tests; this patch adds a warning for those unfortunate enough to encounter it. See also: #208
| @nathanielmanistaatgoogle Squashed and reworded commit message. Does everything look OK? |
| I'm satisfied. @jonparrott will also review and will merge. Thank you for the contribution! |
| LGTM, thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See #208 .
If HttpMock or HttpMockSequence is used in a test without the cache
being filled first, a strange KeyError will be thrown. This happens
on e.g. Travis CI. Unfortunately this behavior is used in the tests;
this patch adds a warning for those unfortunate enough to encounter
it.