Merge pull request #364 from myromr/363/Romar-Marcos

Add Romar Marcos details

Author: joshuadeguzman

assets/data/devs.json

@@ -617,5 +617,20 @@
  "facebook": "https://www.facebook.com/Kyrie.Kills.2/",
  "linkedin": "https://www.linkedin.com/in/john-lester-4669511aa/"
  }
+ },
+ {
+ "name": "Romar Marcos",
+ "roles": [
+ "Information Technology Student",
+ "Web Developer",
+ "Flutter Developer"
+ ],
+ "about": "Your friendly flutterista",
+ "username": "myromr",
+ "socials": {
+ "twitter": "https://twitter.com/_myromr",
+ "facebook": "https://www.facebook.com/myromr/",
+ "linkedin": "https://www.linkedin.com/in/romar-marcos"
+ }
  }
 ]

lib/core/datasource/devs_datasource.dart

@@ -2,4 +2,4 @@ import 'package:devs/core/models/dev.dart';
 
 abstract class IDevsDataSource {
  Future<List<Dev>> getDevs();
-}
+}

lib/core/datasource/memory/devs_memory_datasource.dart

@@ -3,7 +3,6 @@ import 'package:devs/core/models/dev.dart';
 
 // FIXME: This seems redundant since streams stores the list internally
 class DevsMemoryDataSource implements IDevsDataSource {
-
  List<Dev> _devList;
 
  @override
@@ -13,5 +12,4 @@ class DevsMemoryDataSource implements IDevsDataSource {
 
  // TODO: Add a memory datasource abstract class for better polymorphism
  void setCache(List<Dev> devList) => _devList = devList;
-
 }

lib/core/repositories/devs_repository.dart

@@ -20,6 +20,7 @@ class DevsRepository implements IDevsRepository {
  List<Dev> local = await localDataSource.getDevs();
  memoryDataSource.setCache(local);
  return local;
- } else return memory;
+ } else
+ return memory;
  }
 }

lib/features/devboard/devboard_model.dart

@@ -7,6 +7,4 @@ class DevBoardModel extends ChangeNotifier {
  final Stream<List<Dev>> _devsStream;
 
  Stream<List<Dev>> get devsStream => _devsStream;
-
-
 }

lib/features/devboard/devboard_page.dart

@@ -30,7 +30,7 @@ class _DevboardPageState extends State<DevboardPage> {
  stream: devBoardModel.devsStream,
  builder: (context, data) {
  // TODO: Show a progress bar while data is null i.e loading data
-  return DevsList(devs: data?.data ?? []);
+ return DevsList(devs: data?.data ?? []);
  },
  ),
  ),

lib/main.dart

@@ -27,9 +27,7 @@ class _DevsAppState extends State<DevsApp> {
  void initState() {
  devsLocalDataSource = DevsLocalDataSource();
  devsMemoryDataSource = DevsMemoryDataSource();
- devsRepository = DevsRepository(
- devsLocalDataSource, devsMemoryDataSource
- );
+ devsRepository = DevsRepository(devsLocalDataSource, devsMemoryDataSource);
  super.initState();
  }
 

lib/utils/utils.dart

@@ -1,5 +1,7 @@
 extension CaseInsensitive on String {
  bool containsIgnoreCase(String other) {
- return this == null ? false : this.toLowerCase().contains(other.toLowerCase());
+ return this == null
+ ? false
+ : this.toLowerCase().contains(other.toLowerCase());
  }
 }

pubspec.lock

@@ -233,6 +233,13 @@ packages:
  url: "https://pub.dartlang.org"
  source: hosted
  version: "4.3.3"
+ rxdart:
+ dependency: "direct main"
+ description:
+ name: rxdart
+ url: "https://pub.dartlang.org"
+ source: hosted
+ version: "0.25.0"
  sky_engine:
  dependency: transitive
  description: flutter