Skip to content

Commit a66cb3f

Browse files
committed
refactor: improve terminal logging
2 parents 2471940 + 40ef0fc commit a66cb3f

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

pkg/devspace/services/terminal/terminal.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,6 @@ func StartTerminal(
111111
}
112112
}()
113113

114-
before := log.GetBaseInstance().GetLevel()
115-
log.GetBaseInstance().SetLevel(logrus.PanicLevel)
116-
defer log.GetBaseInstance().SetLevel(before)
117-
118114
command := getCommand(devContainer)
119115
container, err := selector.WithContainer(devContainer.Container).SelectSingleContainer(ctx.Context, ctx.KubeClient, ctx.Log)
120116
if err != nil {
@@ -130,6 +126,7 @@ func StartTerminal(
130126
// try to install screen
131127
useScreen := false
132128
if term.IsTerminal(stdin) && !devContainer.Terminal.DisableScreen {
129+
ctx.Log.Debugf("Installing screen in container...")
133130
bufferStdout, bufferStderr, err := ctx.KubeClient.ExecBuffered(ctx.Context, container.Pod, container.Container.Name, []string{
134131
"sh",
135132
"-c",
@@ -167,6 +164,12 @@ fi`,
167164
command = newCommand
168165
}
169166

167+
ctx.Log.Debugf("Starting terminal...")
168+
169+
before := log.GetBaseInstance().GetLevel()
170+
log.GetBaseInstance().SetLevel(logrus.PanicLevel)
171+
defer log.GetBaseInstance().SetLevel(before)
172+
170173
errChan <- ctx.KubeClient.ExecStream(ctx.Context, &kubectl.ExecStreamOptions{
171174
Pod: container.Pod,
172175
Container: container.Container.Name,

0 commit comments

Comments
 (0)