Revise delete tests (CrunchyData#3822)

Revise delete KUTTL tests * Use files for legibility * Add describe/log collectors to every assert

Author: benjaminjb

testing/kuttl/e2e/delete-namespace/00-assert.yaml

@@ -0,0 +1,7 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestAssert
+collectors:
+- type: command
+ command: kubectl -n ${KUTTL_TEST_DELETE_NAMESPACE} describe pods --selector postgres-operator.crunchydata.com/cluster=delete-namespace
+- namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
+ selector: postgres-operator.crunchydata.com/cluster=delete-namespace

testing/kuttl/e2e/delete-namespace/00-create-cluster.yaml

@@ -0,0 +1,7 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- files/00-create-namespace.yaml
+- files/00-create-cluster.yaml
+assert:
+- files/00-created.yaml

testing/kuttl/e2e/delete-namespace/01-assert.yaml

@@ -1,22 +1,7 @@
----
-apiVersion: postgres-operator.crunchydata.com/v1beta1
-kind: PostgresCluster
-metadata:
- name: delete-namespace
- namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
-status:
- instances:
- - name: instance1
- readyReplicas: 1
- replicas: 1
- updatedReplicas: 1
----
-apiVersion: batch/v1
-kind: Job
-metadata:
- namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
- labels:
- postgres-operator.crunchydata.com/cluster: delete-namespace
- postgres-operator.crunchydata.com/pgbackrest-backup: replica-create
-status:
- succeeded: 1
+apiVersion: kuttl.dev/v1beta1
+kind: TestAssert
+collectors:
+- type: command
+ command: kubectl -n ${KUTTL_TEST_DELETE_NAMESPACE} describe pods --selector postgres-operator.crunchydata.com/cluster=delete-namespace
+- namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
+ selector: postgres-operator.crunchydata.com/cluster=delete-namespace

…lete-namespace/02--delete-namespace.yaml …elete-namespace/01-delete-namespace.yamltesting/kuttl/e2e/delete-namespace/02--delete-namespace.yaml renamed to testing/kuttl/e2e/delete-namespace/01-delete-namespace.yaml testing/kuttl/e2e/delete-namespace/02--delete-namespace.yaml renamed to testing/kuttl/e2e/delete-namespace/01-delete-namespace.yaml

@@ -6,3 +6,5 @@ delete:
  - apiVersion: v1
  kind: Namespace
  name: ${KUTTL_TEST_DELETE_NAMESPACE}
+error:
+- files/01-errors.yaml

…tl/e2e/delete-namespace/01--cluster.yaml …e-namespace/files/00-create-cluster.yamltesting/kuttl/e2e/delete-namespace/01--cluster.yaml renamed to testing/kuttl/e2e/delete-namespace/files/00-create-cluster.yaml testing/kuttl/e2e/delete-namespace/01--cluster.yaml renamed to testing/kuttl/e2e/delete-namespace/files/00-create-cluster.yaml

@@ -0,0 +1,22 @@
+---
+apiVersion: postgres-operator.crunchydata.com/v1beta1
+kind: PostgresCluster
+metadata:
+ name: delete-namespace
+ namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
+status:
+ instances:
+ - name: instance1
+ readyReplicas: 1
+ replicas: 1
+ updatedReplicas: 1
+---
+apiVersion: batch/v1
+kind: Job
+metadata:
+ namespace: ${KUTTL_TEST_DELETE_NAMESPACE}
+ labels:
+ postgres-operator.crunchydata.com/cluster: delete-namespace
+ postgres-operator.crunchydata.com/pgbackrest-backup: replica-create
+status:
+ succeeded: 1

…/e2e/delete-namespace/00--namespace.yaml …namespace/files/00-create-namespace.yamltesting/kuttl/e2e/delete-namespace/00--namespace.yaml renamed to testing/kuttl/e2e/delete-namespace/files/00-create-namespace.yaml testing/kuttl/e2e/delete-namespace/00--namespace.yaml renamed to testing/kuttl/e2e/delete-namespace/files/00-create-namespace.yaml

@@ -1,20 +1,7 @@
----
-apiVersion: postgres-operator.crunchydata.com/v1beta1
-kind: PostgresCluster
-metadata:
- name: delete
-status:
- instances:
- - name: instance1
- readyReplicas: 1
- replicas: 1
- updatedReplicas: 1
----
-apiVersion: batch/v1
-kind: Job
-metadata:
- labels:
- postgres-operator.crunchydata.com/cluster: delete
- postgres-operator.crunchydata.com/pgbackrest-backup: replica-create
-status:
- succeeded: 1
+apiVersion: kuttl.dev/v1beta1
+kind: TestAssert
+collectors:
+- type: command
+ command: kubectl -n $NAMESPACE describe pods --selector postgres-operator.crunchydata.com/cluster=delete
+- namespace: $NAMESPACE
+ selector: postgres-operator.crunchydata.com/cluster=delete

testing/kuttl/e2e/delete-namespace/files/00-created.yaml

@@ -0,0 +1,6 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+apply:
+- files/00-create-cluster.yaml
+assert:
+- files/00-cluster-created.yaml