Skip to content

"subject-empty" is over-flagged #2761

@nedbat

Description

@nedbat

Expected Behavior

Lint a comment message like "try out commitlint." Two errors are flagged:

Error: You have commit messages with errors ⧗ input: try out commitlint. ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint 

The "subject-empty" error seems silly: the commit message has a subject, it's "try out commitlint." In my opinion, "subject-empty" should only be raised for messages like "fix:", with a type and nothing else.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions