fix: remove extra class-props babel plugin #363
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
The
@babel/plugin-proposal-class-properties
no longer needs to be explicitly added, as it is now incorporated into@babel/preset-env
. You can see this in a freshly generated RN library by addingdebug: true
to this default configuration:Removing this duplicate entry ensures the optimal application of transforms within the preset-env space. This was discovered while attempting to update
react-native-svg
, which has a pathologic case in theirSymbol.tsx
that causes a babel parser error that is resolved when this entry is removed:Test plan
I reproduced the minimal problem space at https://github.com/merrywhether/rnlib, and also verified that this allows
react-native-svg
to build againstreact-native-builder-bob@0.20.0
(after upgrading it from@react-native-community/bob@0.9.7
).Closes #154.
Unblocks software-mansion/react-native-svg#1993.