benchmark(compiler): add a benchmark measuring view instantiation in AngularDart 1.0

Author: vsavkin

.gitignore

@@ -5,7 +5,7 @@ packages/
 .buildlog
 node_modules
 packages
-
+.pub
 .DS_STORE
 
 # Or the files created by dart2js.

gulpfile.js

@@ -248,59 +248,83 @@ gulp.task('analyze/dartanalyzer', function(done) {
 // ------------------
 // BENCHMARKS JS
 
-gulp.task('benchmarks/build.benchpress.js', function () {
+gulp.task('benchmarks/internal.benchpress.js', function () {
  benchpress.build({
  benchmarksPath: 'build/js/benchmarks/lib',
  buildPath: 'build/benchpress/js'
  })
 });
 
-gulp.task('benchmarks/build.js', function() {
+gulp.task('benchmarks/external.benchpress.js', function () {
+ benchpress.build({
+ benchmarksPath: 'build/js/benchmarks_external/lib',
+ buildPath: 'build/benchpress/js'
+ })
+});
+
+gulp.task('benchmarks/internal.js', function() {
  runSequence(
  ['jsRuntime/build', 'modules/build.prod.js'],
- 'benchmarks/build.benchpress.js'
+ 'benchmarks/internal.benchpress.js'
+ );
+});
+
+gulp.task('benchmarks/external.js', function() {
+ runSequence(
+ ['jsRuntime/build', 'modules/build.prod.js'],
+ 'benchmarks/external.benchpress.js'
  );
 });
 
 
 // ------------------
 // BENCHMARKS DART
 
-gulp.task('benchmarks/build.dart2js.dart', function () {
- return gulp.src([
- "build/dart/benchmarks/lib/**/benchmark.dart"
- ]).pipe($.shell(['dart2js --package-root="build/dart/benchmarks/packages" -o "<%= file.path %>.js" <%= file.path %>']));
-});
+function benchmarkDart2Js(buildPath, done) {
 
-gulp.task('benchmarks/create-bpconf.dart', function () {
- var bpConfContent = "module.exports = function(c) {c.set({scripts: [{src: 'benchmark.dart.js'}]});}";
- var createBpConfJs = es.map(function(file, cb) {
- var dir = path.dirname(file.path);
- fs.writeFileSync(path.join(dir, "bp.conf.js"), bpConfContent);
- cb();
- });
+ mergeStreams(dart2jsStream(), bpConfStream())
+ .on('end', function() {
+ runBenchpress();
+ done();
+ });
 
- return gulp.src([
- "build/dart/benchmarks/lib/**/benchmark.dart"
- ]).pipe(createBpConfJs);
-});
+ function dart2jsStream() {
+ return gulp.src([
+ buildPath+"/lib/**/benchmark.dart"
+ ]).pipe($.shell(['dart2js --package-root="'+buildPath+'/packages" -o "<%= file.path %>.js" <%= file.path %>']));
+ }
 
-gulp.task('benchmarks/build.benchpress.dart', function () {
- benchpress.build({
- benchmarksPath: 'build/dart/benchmarks/lib',
- buildPath: 'build/benchpress/dart'
- })
+ function bpConfStream() {
+ var bpConfContent = "module.exports = function(c) {c.set({scripts: [{src: 'benchmark.dart.js'}]});}";
+ var createBpConfJs = es.map(function(file, cb) {
+ var dir = path.dirname(file.path);
+ fs.writeFileSync(path.join(dir, "bp.conf.js"), bpConfContent);
+ cb();
+ });
+
+ return gulp.src([
+ buildPath+"/lib/**/benchmark.dart"
+ ]).pipe(createBpConfJs);
+ }
+
+ function runBenchpress() {
+ benchpress.build({
+ benchmarksPath: buildPath+'/lib',
+ buildPath: 'build/benchpress/dart'
+ });
+ }
+}
+
+gulp.task('benchmarks/internal.dart', ['modules/build.dart'], function(done) {
+ benchmarkDart2Js('build/dart/benchmarks', done);
 });
 
-gulp.task('benchmarks/build.dart', function() {
- runSequence(
- 'modules/build.dart',
- 'benchmarks/build.dart2js.dart',
- 'benchmarks/create-bpconf.dart',
- 'benchmarks/build.benchpress.dart'
- );
+gulp.task('benchmarks/external.dart', ['modules/build.dart'], function(done) {
+ benchmarkDart2Js('build/dart/benchmarks_external', done);
 });
 
+gulp.task('benchmarks/build.dart', ['benchmarks/internal.dart', 'benchmarks/external.dart']);
+
 
 
 // ------------------

modules/benchmarks/pubspec.yaml

@@ -6,6 +6,8 @@ dependencies:
  path: ../facade
  di:
  path: ../di
+ reflection:
+ path: ../reflection
  core:
  path: ../core
  change_detection:

modules/benchmarks/src/compiler/benchmark.es5

@@ -1,7 +1,6 @@
 Promise.all([
  System.import('benchmarks/compiler/selector_benchmark'),
- System.import('benchmarks/compiler/compiler_benchmark'),
- System.import('benchmarks/compiler/compiler_benchmark_ng13')
+ System.import('benchmarks/compiler/compiler_benchmark')
 ]).then(function (benchmarks) {
  benchmarks.forEach(function(bm) {
  bm.main();

modules/benchmarks/src/compiler/bp.conf.es5

@@ -5,7 +5,6 @@ module.exports = function(config) {
  {src: '/js/es6-module-loader-sans-promises.src.js'},
  {src: '/js/extension-register.js'},
  {src: 'register_system.js'},
- {src: 'https://ajax.googleapis.com/ajax/libs/angularjs/1.3.2/angular.js'},
  {src: 'benchmark.js'}
  ]
  });

modules/benchmarks/src/compiler/compiler_benchmark.js

@@ -7,6 +7,7 @@ import {AnnotatedType} from 'core/compiler/annotated_type';
 
 import {Parser} from 'change_detection/parser/parser';
 import {Lexer} from 'change_detection/parser/lexer';
+import {ProtoRecordRange} from 'change_detection/record_range';
 
 import {Compiler} from 'core/compiler/compiler';
 import {DirectiveMetadataReader} from 'core/compiler/directive_metadata_reader';
@@ -15,12 +16,70 @@ import {Component} from 'core/annotations/annotations';
 import {Decorator} from 'core/annotations/annotations';
 import {TemplateConfig} from 'core/annotations/template_config';
 
+import {reflector} from 'reflection/reflection';
+
 var COUNT = 30;
 
 var compiler;
 var annotatedComponent;
 
 function setup() {
+ reflector.registerType(BenchmarkComponent, {
+ "factory": () => new BenchmarkComponent(),
+ "parameters": [],
+ "annotations" : [new Component({template: new TemplateConfig({directives: [Dir0, Dir1, Dir2, Dir3, Dir4]})})]
+ });
+
+ reflector.registerType(Dir0, {
+ "factory": () => new Dir0(),
+ "parameters": [],
+ "annotations" : [new Decorator({selector: '[dir0]', bind: {'attr0': 'prop'}})]
+ });
+
+ reflector.registerType(Dir1, {
+ "factory": (dir0) => new Dir1(dir0),
+ "parameters": [[Dir0]],
+ "annotations" : [new Decorator({selector: '[dir1]', bind: {'attr1': 'prop'}})]
+ });
+
+ reflector.registerType(Dir2, {
+ "factory": (dir1) => new Dir2(dir1),
+ "parameters": [[Dir1]],
+ "annotations" : [new Decorator({selector: '[dir2]', bind: {'attr2': 'prop'}})]
+ });
+
+ reflector.registerType(Dir3, {
+ "factory": (dir2) => new Dir3(dir2),
+ "parameters": [[Dir2]],
+ "annotations" : [new Decorator({selector: '[dir3]', bind: {'attr3': 'prop'}})]
+ });
+
+ reflector.registerType(Dir4, {
+ "factory": (dir3) => new Dir4(dir3),
+ "parameters": [[Dir3]],
+ "annotations" : [new Decorator({selector: '[dir4]', bind: {'attr4': 'prop'}})]
+ });
+
+ reflector.registerGetters({
+ "inter0": (a) => a.inter0, "inter1": (a) => a.inter1, 
+ "inter2": (a) => a.inter2, "inter3": (a) => a.inter3, "inter4": (a) => a.inter4,
+
+ "value0": (a) => a.value0, "value1": (a) => a.value1,
+ "value2": (a) => a.value2, "value3": (a) => a.value3, "value4": (a) => a.value4,
+
+ "prop" : (a) => a.prop
+ });
+
+ reflector.registerSetters({
+ "inter0": (a,v) => a.inter0 = v, "inter1": (a,v) => a.inter1 = v,
+ "inter2": (a,v) => a.inter2 = v, "inter3": (a,v) => a.inter3 = v, "inter4": (a,v) => a.inter4 = v,
+
+ "value0": (a,v) => a.value0 = v, "value1": (a,v) => a.value1 = v,
+ "value2": (a,v) => a.value2 = v, "value3": (a,v) => a.value3 = v, "value4": (a,v) => a.value4 = v,
+
+ "prop": (a,v) => a.prop = v
+ });
+
  var reader = new CachingDirectiveMetadataReader();
  compiler = new Compiler(null, reader, new Parser(new Lexer()));
  annotatedComponent = reader.annotatedType(BenchmarkComponent);
@@ -48,6 +107,19 @@ export function main() {
  compiler.compileWithCache(null, annotatedComponent, cloned);
  });
  });
+
+ benchmark(`instantiate 5*${COUNT} element with bindings`, function() {
+ var template = loadTemplate('templateWithBindings', COUNT);
+ var protoView = compiler.compileWithCache(null, annotatedComponent, template);
+ var rootRecordRange = new ProtoRecordRange().instantiate(null, new Object());
+
+ benchmarkStep('run', function() {
+ var view = protoView.instantiate(null, null, null);
+ // also include adding / removing the RecordRange from the parent in the benchmark.
+ rootRecordRange.addRange(view.recordRange);
+ view.recordRange.remove();
+ });
+ });
 }
 
 function loadTemplate(templateId, repeatCount) {
@@ -90,31 +162,39 @@ class Dir0 {}
  'attr1': 'prop'
  }
 })
-class Dir1 {}
+class Dir1 {
+ constructor(dir0:Dir0) {}
+}
 
 @Decorator({
  selector: '[dir2]',
  bind: {
  'attr2': 'prop'
  }
 })
-class Dir2 {}
+class Dir2 {
+ constructor(dir1:Dir1) {}
+}
 
 @Decorator({
  selector: '[dir3]',
  bind: {
  'attr3': 'prop'
  }
 })
-class Dir3 {}
+class Dir3 {
+ constructor(dir2:Dir2) {}
+}
 
 @Decorator({
  selector: '[dir4]',
  bind: {
  'attr4': 'prop'
  }
 })
-class Dir4 {}
+class Dir4 {
+ constructor(dir3:Dir3) {}
+}
 
 @Component({
  template: new TemplateConfig({

modules/benchmarks_external/pubspec.yaml

@@ -0,0 +1,5 @@
+name: benchmarks_external
+environment:
+ sdk: '>=1.4.0'
+dependencies:
+ angular: ">=1.0.0 <2.0.0"

modules/benchmarks_external/src/benchpress.dart

@@ -0,0 +1,63 @@
+library benchmarks.benchpress;
+
+import 'dart:js' as js;
+import 'dart:html';
+import 'dart:async';
+
+// TODO: move the functionality of this module into benchpress and replace this
+// file with a Dart wrapper!
+
+var _benchmarkNames = [];
+
+_benchmarkId(index) {
+ return "benchmark${index}";
+}
+
+_useBenchmark(index) {
+ var search = window.location.search;
+ if (search.length > 0) {
+ search = search.substring(1);
+ }
+ if (search.length > 0) {
+ return search == _benchmarkId(index);
+ } else {
+ return true;
+ }
+}
+
+_onLoad(callback) {
+ var isReady = document.readyState == 'complete';
+ if (isReady) {
+ Timer.run(callback);
+ } else {
+ window.addEventListener('load', (event) => callback(), false);
+ }
+}
+
+_createBenchmarkMenu() {
+ var div = document.createElement('div');
+ div.innerHtml += '<h1>Benchmarks:</h1><a class="btn btn-default" href="?">All</a>';
+ for (var i=0; i<_benchmarkNames.length; i++) {
+ var activeClass = _useBenchmark(i) ? 'active' : '';
+ div.innerHtml += '<a class="btn btn-default ${activeClass}" href="?${_benchmarkId(i)}">${_benchmarkNames[i]}</a>';
+ }
+ document.body.insertBefore(div, document.body.childNodes[0]);
+}
+
+benchmark(name, stepsCreationCallback) {
+ _benchmarkNames.add(name);
+ if (_benchmarkNames.length == 2) {
+ _onLoad(_createBenchmarkMenu);
+ }
+ if (_useBenchmark(_benchmarkNames.length-1)) {
+ stepsCreationCallback();
+ }
+}
+
+benchmarkStep(name, callback) {
+ var benchmarkName = _benchmarkNames[_benchmarkNames.length-1];
+ js.context['benchmarkSteps'].add(new js.JsObject.jsify({
+ "name": benchmarkName + '#' + name,
+ "fn": new js.JsFunction.withThis((_) => callback())
+ }));
+}