Skip to content

Conversation

@piotr-oles
Copy link
Collaborator

Based on the #512 - added e2e tests

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 16346 lines exceeds the maximum allowed for the inline comments feature.

@piotr-oles piotr-oles force-pushed the webpack-formatter-context branch from b86ac6a to 705db50 Compare October 26, 2020 21:52
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 705db50 and detected 0 issues on this pull request.

View more on Code Climate.

@piotr-oles piotr-oles merged commit cadede8 into master Oct 28, 2020
@piotr-oles piotr-oles deleted the webpack-formatter-context branch October 28, 2020 08:15
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 6.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eamodio
Copy link
Contributor

eamodio commented Nov 5, 2020

@piotr-oles I was hoping this change would fix an issue I am seeing where the error reporting isn't based on the cwd, but a nested sub-folder.

In my case (here), I have 2 parallel webpack configs (1 for my extension & 1 for its webviews). The error reporting for the extension work fine (as the files are in src/), but the reporting for the webviews are relative to src/webviews/apps which causes issues with problem matchers (in vscode).

Am I wrong in thinking that these changes would have resolved this?

@piotr-oles
Copy link
Collaborator Author

Could you try to upgrade to 6.0.0-alpha.3? You use 6.0.0-alpha.2 which doesn't contain this change:

fork-ts-checker-webpack-plugin@6.0.0-alpha.2: version "6.0.0-alpha.2" resolved "https://registry.yarnpkg.com/fork-ts-checker-webpack-plugin/-/fork-ts-checker-webpack-plugin-6.0.0-alpha.2.tgz#9a3ff105f1ad9905d344691142917a4a26742a6c" integrity sha512-wpgTOeOJ2QADI6wy0zqOsepfQDCK1E3Msx8xsCmGDjNjPS5lfx9PwxXg1VfGfsqw/uXMv2qgZc49KKFXH/w/KA== dependencies: "@babel/code-frame" "^7.8.3" "@types/json-schema" "^7.0.5" chalk "^4.1.0" chokidar "^3.4.2" cosmiconfig "^6.0.0" deepmerge "^4.2.2" fs-extra "^9.0.0" memfs "^3.1.2" minimatch "^3.0.4" schema-utils "2.7.0" semver "^7.3.2" tapable "^1.0.0" 
@eamodio
Copy link
Contributor

eamodio commented Nov 6, 2020

@eamodio
Copy link
Contributor

eamodio commented Nov 9, 2020

@piotr-oles any idea on this one?

@piotr-oles
Copy link
Collaborator Author

I haven't time to look into this :/ I hope I will find some time this week :)

@piotr-oles
Copy link
Collaborator Author

@eamodio I found a bug - fix is on the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment