refactor(@angular-devkit/build-webpack): reduce complexity of get emitted files helper function

The deduplication logic is now inline with the chunk and asset iteration and is checked via a Set instead of a follow-up step.

Author: clydin

goldens/public-api/angular_devkit/build_webpack/src/index.md

@@ -24,7 +24,7 @@ export type DevServerBuildOutput = BuildResult & {
  address: string;
 };
 
-// @public (undocumented)
+// @public
 export interface EmittedFiles {
  // (undocumented)
  asset?: boolean;

packages/angular_devkit/build_webpack/src/utils.ts

@@ -7,7 +7,6 @@
  */
 
 import * as path from 'path';
-import * as webpack from 'webpack';
 
 export interface EmittedFiles {
  id?: string;
@@ -18,16 +17,20 @@ export interface EmittedFiles {
  extension: string;
 }
 
-export function getEmittedFiles(compilation: webpack.Compilation): EmittedFiles[] {
+export function getEmittedFiles(compilation: import('webpack').Compilation): EmittedFiles[] {
  const files: EmittedFiles[] = [];
+ const chunkFileNames = new Set<string>();
 
  // adds all chunks to the list of emitted files such as lazy loaded modules
- for (const chunk of compilation.chunks as Iterable<webpack.Chunk>) {
+ for (const chunk of compilation.chunks) {
  for (const file of chunk.files) {
+ if (chunkFileNames.has(file)) {
+ continue;
+ }
+
+ chunkFileNames.add(file);
  files.push({
- // The id is guaranteed to exist at this point in the compilation process
- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
- id: chunk.id!.toString(),
+ id: chunk.id?.toString(),
  name: chunk.name,
  file,
  extension: path.extname(file),
@@ -36,14 +39,15 @@ export function getEmittedFiles(compilation: webpack.Compilation): EmittedFiles[
  }
  }
 
- // other all files
+ // add all other files
  for (const file of Object.keys(compilation.assets)) {
+ // Chunk files have already been added to the files list above
+ if (chunkFileNames.has(file)) {
+ continue;
+ }
+
  files.push({ file, extension: path.extname(file), initial: false, asset: true });
  }
 
- // dedupe
- return files.filter(
- ({ file, name }, index) =>
- files.findIndex((f) => f.file === file && (!name || name === f.name)) === index,
- );
+ return files;
 }