Skip to content

Commit 941b327

Browse files
author
Kent C. Dodds
committed
use find by because it is better
1 parent acf7eb5 commit 941b327

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/__tests__/tdd-07-error-state.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react'
2-
import {render, fireEvent, wait, waitForElement} from '@testing-library/react'
2+
import {render, fireEvent, wait} from '@testing-library/react'
33
import {build, fake, sequence} from 'test-data-bot'
44
import {Redirect as MockRedirect} from 'react-router'
55
import {savePost as mockSavePost} from '../api'
@@ -61,7 +61,7 @@ test('renders an error message from the server', async () => {
6161
const testError = 'test error'
6262
mockSavePost.mockRejectedValueOnce({data: {error: testError}})
6363
const fakeUser = userBuilder()
64-
const {getByLabelText, getByText, getByRole} = render(
64+
const {getByLabelText, getByText, findByRole} = render(
6565
<Editor user={fakeUser} />,
6666
)
6767
const fakePost = postBuilder()
@@ -73,7 +73,7 @@ test('renders an error message from the server', async () => {
7373

7474
fireEvent.click(submitButton)
7575

76-
const postError = await waitForElement(() => getByRole('alert'))
76+
const postError = await findByRole('alert')
7777
expect(postError).toHaveTextContent(testError)
7878
expect(submitButton).not.toBeDisabled()
7979
})

src/__tests__/tdd-08-custom-render.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react'
2-
import {render, fireEvent, wait, waitForElement} from '@testing-library/react'
2+
import {render, fireEvent, wait} from '@testing-library/react'
33
import {build, fake, sequence} from 'test-data-bot'
44
import {Redirect as MockRedirect} from 'react-router'
55
import {savePost as mockSavePost} from '../api'
@@ -70,11 +70,11 @@ test('renders a form with title, content, tags, and a submit button', async () =
7070
test('renders an error message from the server', async () => {
7171
const testError = 'test error'
7272
mockSavePost.mockRejectedValueOnce({data: {error: testError}})
73-
const {submitButton, getByRole} = renderEditor()
73+
const {submitButton, findByRole} = renderEditor()
7474

7575
fireEvent.click(submitButton)
7676

77-
const postError = await waitForElement(() => getByRole('alert'))
77+
const postError = await findByRole('alert')
7878
expect(postError).toHaveTextContent(testError)
7979
expect(submitButton).not.toBeDisabled()
8080
})

0 commit comments

Comments
 (0)