"The Metro Server" -> Metro

Summary: Pet Peeve: Metro is a brand name. You don't say "the Metro server" just like you don't say "the iPhone phone". This is a leftover from when it used to be called "the packager server". Note: It makes sense to refer to "the Metro server" when talking about it in the context of Metro's features, like if you are discussing "Metro's bundling" and "Metro's server". However, when talking about the tool itself, just Metro is enough. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D22330966 fbshipit-source-id: 667618363c641884df543d88cac65d1e44956ad3

Author: cpojer

.circleci/Dockerfiles/scripts/run-ci-e2e-tests.sh

@@ -199,7 +199,7 @@ function e2e_suite() {
  return 1
  fi
 
- echo "Starting packager server"
+ echo "Starting Metro"
  npm start >> /dev/null &
  SERVER_PID=$!
  sleep 15

Libraries/Utilities/HMRClient.js

@@ -172,14 +172,14 @@ const HMRClient: HMRClientNativeInterface = {
  );
 
  client.on('connection-error', e => {
- let error = `Cannot connect to the Metro server.
+ let error = `Cannot connect to Metro.
 
 Try the following to fix the issue:
-- Ensure that the Metro server is running and available on the same network`;
+- Ensure that Metro is running and available on the same network`;
 
  if (Platform.OS === 'ios') {
  error += `
-- Ensure that the Metro server URL is correctly set in AppDelegate`;
+- Ensure that the Metro URL is correctly set in AppDelegate`;
  } else {
  error += `
 - Ensure that your device/emulator is connected to your machine and has USB debugging enabled - run 'adb devices' to see a list of connected devices
@@ -222,12 +222,12 @@ Error: ${e.message}`;
  if (data.type === 'GraphNotFoundError') {
  client.close();
  setHMRUnavailableReason(
- 'The Metro server has restarted since the last edit. Reload to reconnect.',
+ 'Metro has restarted since the last edit. Reload to reconnect.',
  );
  } else if (data.type === 'RevisionNotFoundError') {
  client.close();
  setHMRUnavailableReason(
- 'The Metro server and the client are out of sync. Reload to reconnect.',
+ 'Metro and the client are out of sync. Reload to reconnect.',
  );
  } else {
  currentCompileErrorMessage = `${data.type} ${data.message}`;
@@ -239,7 +239,7 @@ Error: ${e.message}`;
 
  client.on('close', data => {
  LoadingView.hide();
- setHMRUnavailableReason('Disconnected from the Metro server.');
+ setHMRUnavailableReason('Disconnected from Metro.');
  });
 
  if (isEnabled) {

React/CoreModules/RCTWebSocketExecutor.mm

@@ -98,7 +98,7 @@ - (void)setUp
  [self invalidate];
  NSString *error =
  @"Runtime is not ready for debugging.\n "
- "- Make sure Packager server is running.\n"
+ "- Make sure Metro is running.\n"
  "- Make sure the JavaScript Debugger is running and not paused on a "
  "breakpoint or exception and try reloading again.";
  _setupError = RCTErrorWithMessage(error);
@@ -165,7 +165,7 @@ - (void)sendMessage:(NSDictionary<NSString *, id> *)message onReply:(RCTWSMessag
 
  dispatch_async(_jsQueue, ^{
  if (!self.valid) {
- callback(RCTErrorWithMessage(@"Runtime is not ready for debugging. Make sure Packager server is running."), nil);
+ callback(RCTErrorWithMessage(@"Runtime is not ready for debugging. Make sure Metro is running."), nil);
  return;
  }
 

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -152,7 +152,7 @@ public interface ReactInstanceEventListener {
  private final JavaScriptExecutorFactory mJavaScriptExecutorFactory;
 
  private final @Nullable JSBundleLoader mBundleLoader;
- private final @Nullable String mJSMainModulePath; /* path to JS bundle root on packager server */
+ private final @Nullable String mJSMainModulePath; /* path to JS bundle root on Metro */
  private final List<ReactPackage> mPackages;
  private final DevSupportManager mDevSupportManager;
  private final boolean mUseDeveloperSupport;

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

@@ -118,9 +118,9 @@ public ReactInstanceManagerBuilder setJSBundleLoader(JSBundleLoader jsBundleLoad
  }
 
  /**
- * Path to your app's main module on the packager server. This is used when reloading JS during
- * development. All paths are relative to the root folder the packager is serving files from.
- * Examples: {@code "index.android"} or {@code "subdirectory/index.android"}
+ * Path to your app's main module on Metro. This is used when reloading JS during development. All
+ * paths are relative to the root folder the packager is serving files from. Examples: {@code
+ * "index.android"} or {@code "subdirectory/index.android"}
  */
  public ReactInstanceManagerBuilder setJSMainModulePath(String jsMainModulePath) {
  mJSMainModulePath = jsMainModulePath;

ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

@@ -118,9 +118,9 @@ protected UIImplementationProvider getUIImplementationProvider() {
  }
 
  /**
- * Returns the name of the main module. Determines the URL used to fetch the JS bundle from the
- * packager server. It is only used when dev support is enabled. This is the first file to be
- * executed once the {@link ReactInstanceManager} is created. e.g. "index.android"
+ * Returns the name of the main module. Determines the URL used to fetch the JS bundle from Metro.
+ * It is only used when dev support is enabled. This is the first file to be executed once the
+ * {@link ReactInstanceManager} is created. e.g. "index.android"
  */
  protected String getJSMainModuleName() {
  return "index.android";
@@ -138,7 +138,7 @@ protected String getJSMainModuleName() {
  /**
  * Returns the name of the bundle in assets. If this is null, and no file path is specified for
  * the bundle, the app will only work with {@code getUseDeveloperSupport} enabled and will always
- * try to load the JS bundle from the packager server. e.g. "index.android.bundle"
+ * try to load the JS bundle from Metro. e.g. "index.android.bundle"
  */
  protected @Nullable String getBundleAssetName() {
  return "index.android.bundle";

ReactAndroid/src/main/java/com/facebook/react/common/DebugServerException.java

@@ -21,7 +21,7 @@
 public class DebugServerException extends RuntimeException {
  private static final String GENERIC_ERROR_MESSAGE =
  "\n\nTry the following to fix the issue:\n"
- + "\u2022 Ensure that the packager server is running\n"
+ + "\u2022 Ensure that Metro is running\n"
  + "\u2022 Ensure that your device/emulator is connected to your machine and has USB debugging enabled - run 'adb devices' to see a list of connected devices\n"
  + "\u2022 Ensure Airplane Mode is disabled\n"
  + "\u2022 If you're on a physical device connected to the same machine, run 'adb reverse tcp:<PORT> tcp:<PORT>' to forward requests from your device\n"

ReactAndroid/src/main/java/com/facebook/react/devsupport/HMRClient.java

@@ -12,14 +12,14 @@
 /**
  * JS module interface for HMRClient
  *
- * <p>The HMR(Hot Module Replacement)Client allows for the application to receive updates from the
- * packager server (over a web socket), allowing for injection of JavaScript to the running
- * application (without a refresh).
+ * <p>The HMR(Hot Module Replacement)Client allows for the application to receive updates from Metro
+ * (over a web socket), allowing for injection of JavaScript to the running application (without a
+ * refresh).
  */
 public interface HMRClient extends JavaScriptModule {
 
  /**
- * Enable the HMRClient so that the client will receive updates from the packager server.
+ * Enable the HMRClient so that the client will receive updates from Metro.
  *
  * @param platform The platform in which HMR updates will be enabled. Should be "android".
  * @param bundleEntry The path to the bundle entry file (e.g. index.ios.bundle).

ReactAndroid/src/main/jni/react/jni/JSLoader.cpp

@@ -66,7 +66,7 @@ loadScriptFromAssets(AAssetManager *manager, const std::string &assetName) {
 
  throw std::runtime_error(folly::to<std::string>(
  "Unable to load script. Make sure you're "
- "either running a Metro server (run 'react-native start') or that your bundle '",
+ "either running Metro (run 'react-native start') or that your bundle '",
  assetName,
  "' is packaged correctly for release."));
 }

scripts/android-e2e-test.js

@@ -84,7 +84,7 @@ describe('Android Test App', function() {
  };
 
  // React Native in dev mode often starts with Red Box "Can't fibd variable __fbBatchedBridge..."
- // This is fixed by clicking Reload JS which will trigger a request to packager server
+ // This is fixed by clicking Reload JS which will trigger a request to Metro
  return driver
  .init(desired)
  .setImplicitWaitTimeout(5000)