Sprint 12 #276
Merged
Sprint 12 #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Fixed bug (remove QB.Recorder) * remove QB.Recorder * upd recorder * upd npm install rimraf -g
Add a few section of docs (QB.chat.*)
* generate new docs
# Conflicts: # docs/QB.chat.html # docs/QB.chat.muc.html # docs/QB.chat.roster.html # docs/QB.html # docs/global.html # docs/index.html # package.json # quickblox.min.js # src/qbConfig.js
* in develop. * done * remove in develop values * review
* qbLocation depcated * session. filter/snapshot removed
* Fixed some text in Data Sample; * Fixed XML stanza for send message with attachments in nodejs environment; * Fixed file's size for response from QB.content.createAndUpload(file, callback); * Added ignores for npm (.npmignore file).
* QBWEBSDK-559 * QBWEBSDK-574 * QBWEBSDK-569 * QBWEBSDK-569 (updated)
* API Reference (Added description for user, content, data and pushnotifications modules) * cleanup * Updated QB.content.upload description
…blox-javascript-sdk into develop # Conflicts: # docs/QB.chat.dialog.html # docs/QB.chat.helpers.html # docs/QB.chat.html # docs/QB.chat.message.html # docs/QB.chat.muc.html # docs/QB.chat.privacylist.html # docs/QB.chat.roster.html # docs/QB.html # docs/global.html # docs/index.html # package-lock.json # quickblox.min.js # src/modules/qbContent.js # src/qbConfig.js
* Added last user activity query. * rebuild after merge * cleanup * rebuild * updated API Reference Docs, Removed method setAsActive in privacyList module, updated tests * rebuild
soulfly reviewed Nov 7, 2017
src/modules/AddressBook.js Outdated
| AddressBook.prototype = { | ||
| /** | ||
| * The method is used to create, update and delete contacts in address book.<br /> | ||
| * If contacts doesn't exist in address book then it will be created. If contacts exists then it will be updated. |
soulfly reviewed Nov 7, 2017
src/modules/AddressBook.js Outdated
| * @memberof QB.addressbook | ||
| * @param {string|function} udidOrCallback - You could pass udid of address book or | ||
| * callback function if you want to get contacts from global address book. | ||
| * @param {function} [callback] - Callback function is uses as 2nd parameter if you pass udid as 1st parameters. |
soulfly reviewed Nov 7, 2017
src/modules/AddressBook.js Outdated
| * Retrive all user that has phone number from your address book. | ||
| * The methods accepts 1 or 2 parameters. | ||
| * @memberof QB.addressbook | ||
| * @param {boolean|function} udidOrCallback - You can pass isCompact parameter or callback object. If isCompact is passed then only user's id and phone fields will be returned from server. Otherwise - all standard user's parameters will be returned. |
Contributor
There was a problem hiding this comment.
user's parameters -> user's fields
soulfly reviewed Nov 7, 2017
src/modules/AddressBook.js Outdated
| * The methods accepts 1 or 2 parameters. | ||
| * @memberof QB.addressbook | ||
| * @param {boolean|function} udidOrCallback - You can pass isCompact parameter or callback object. If isCompact is passed then only user's id and phone fields will be returned from server. Otherwise - all standard user's parameters will be returned. | ||
| * @param {function} [callback] - Callback function is uses as 2nd parameter if you pass `isCompact` as 1st parameters. |
Contributor
There was a problem hiding this comment.
is uses -> is used
as 1st parameters. -> as 1st parameter.
soulfly reviewed Nov 7, 2017
src/modules/AddressBook.js Outdated
| }, | ||
| | ||
| /** | ||
| * Retrive all user that has phone number from your address book. |
Contributor
There was a problem hiding this comment.
Retrive all user that has phone number from your address book. -> Retrieve QuickBlox users that have phone numbers from your address book.
Contributor
| Just a quick question: Why you decided to have a separate callback for Last Activity instead of the following? : |
Contributor Author
| "Why you decided to have a separate callback for Last Activity instead of the following?" To keep one-sided, because the whole chat is working on listeners. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added:
Updated:
Removed:
Samples:
How should this be manually tested?
Use Jasmine, start ./spec/SpecRunner.html in browser
Does the documentation need an update?
Yes, generate JSDOC before release