Skip to content

new DATA sample #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 14, 2017
Merged

new DATA sample #262

merged 10 commits into from
Jul 14, 2017

Conversation

@dimaspirit
Copy link
Contributor

@dimaspirit dimaspirit commented Jul 13, 2017 •
edited
Loading

Made/Proposed changes:

  • Data sample;

How should this be manually tested?
npm run start & localhost:8080/samples/data

Does the documentation need an update?
No
@dimaspirit dimaspirit requested a review from a team July 13, 2017 13:00
Vladlukhanin
Vladlukhanin reviewed Jul 13, 2017
View reviewed changes
samples/data/js/app.js


function App() {
this.ui = {
Copy link
Contributor

@Vladlukhanin Vladlukhanin Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon
Vladlukhanin
Vladlukhanin reviewed Jul 13, 2017
View reviewed changes
samples/webrtc/styles.css Outdated
@@ -1,4 +1,4 @@
@import url(https://fonts.googleapis.com/css?family=Open+Sans:400,300,600,700,800&subset=latin,latin-ext);
/*@import url(https://fonts.googleapis.com/css?family=Open+Sans:400,300,600,700,800&subset=latin,latin-ext);*/
Copy link
Contributor

@Vladlukhanin Vladlukhanin Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?
Vladlukhanin
Vladlukhanin reviewed Jul 13, 2017
View reviewed changes
Copy link
Contributor

@Vladlukhanin Vladlukhanin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't forget about multiple requests to get all data (for example - Places.sync(), Checkin.get() )
  2. App can't detect current position after allowing permissions in Safari browser.
@soulfly soulfly self-requested a review July 13, 2017 15:15
@soulfly
Copy link
Contributor

soulfly commented Jul 13, 2017

Approved
@dimaspirit dimaspirit merged commit f514b11 into develop Jul 14, 2017
@dimaspirit dimaspirit deleted the develop.QBWEBSDK-511 branch July 14, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@dimaspirit @soulfly @Vladlukhanin