Develop.new chat sample fixes #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
IegorKozakov commented May 16, 2017
IegorKozakov commented - Fixes with sending messages in a group chat.
- Add room name.
- Update dialog fixes.
- Users count on the create dialog page.
dimaspirit reviewed May 16, 2017
samples/newChat/css/dashboard.css Outdated
| font-weight: 500; | ||
| line-height: 20px; | ||
| color: #4A4A4A; | ||
| margin: 0 0 6px; |
dimaspirit reviewed May 16, 2017
| }); | ||
| | ||
| }).catch(function(error){ | ||
| console.error(error); |
Contributor Author
There was a problem hiding this comment.
Yes. I use console.error() to notify developers about the errors in catch part of the promise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.