Develop.sprint6.stream management #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dimaspirit reviewed Dec 7, 2016
src/modules/qbChat.js Outdated
| }; | ||
| }; | ||
| } else { | ||
| console.warn('[QBchat] StreamManagement:', 'Stream management does not supported by BOSH protocol. Set WebSocket as the "chatProtocol" parameter to use this functionality. http://quickblox.com/developers/Javascript#Configuration'); |
Contributor
There was a problem hiding this comment.
Use our logger
See Utils
dimaspirit reviewed Dec 14, 2016
src/modules/qbChat.js Outdated
| }; | ||
| }; | ||
| } else { | ||
| Utils.QBLog('[QBchat] StreamManagement:', 'Stream management does not supported by BOSH protocol. Set WebSocket as the "chatProtocol" parameter to use this functionality. http://quickblox.com/developers/Javascript#Configuration'); |
Contributor
There was a problem hiding this comment.
Stream management does not supported by BOSH protocol == > Stream management does not support by BOSH protocol.
Contributor Author
There was a problem hiding this comment.
This is passive voice, that's why "supported" is correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make sure that you wrote the tests for your proposed changes and the existing test was success.
Made/Proposed changes:
(Don’t use general words, describe changes in details)
How should this be manually tested?
Does the documentation need an update?