Automatically create DB schema on connect

Reduces copy paste and adds confidence that someone won't try manipulate with DB before schema is created

Author: nikitabobko

contract-creator/src/org/jetbrains/ruby/runtime/signature/server/SignatureServer.kt

@@ -27,7 +27,6 @@ fun main(args: Array<String>) {
  parseArgs(args).let {
  DatabaseProvider.connectToDB(it.dbFilePath, isDefaultDatabase = true)
  }
- DatabaseProvider.createAllDatabases()
 
  val pipeFileName = SignatureServer().runServerAsync(isDaemon = false)
  println("Pass this to arg-scanner via --pipe-file-path: $pipeFileName")

ide-plugin/src/org/jetbrains/plugins/ruby/ruby/actions/ImportExportContractsAction.kt

@@ -70,7 +70,6 @@ class ExportContractsAction : ExportFileActionBase(
  File(pathToExport).delete()
 
  val databaseToExportTo = DatabaseProvider.connectToDB(pathToExport)
- DatabaseProvider.createAllDatabases(databaseToExportTo)
 
  DatabaseProvider.defaultDatabase!!.copyTo(databaseToExportTo, moveProgressBar)
  }

ide-plugin/src/org/jetbrains/plugins/ruby/ruby/codeInsight/ProjectLifecycleListenerImpl.kt

@@ -1,7 +1,6 @@
 package org.jetbrains.plugins.ruby.ruby.codeInsight
 
 import com.google.gson.Gson
-import com.intellij.openapi.diagnostic.Logger
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.project.ProjectManagerListener
 import org.jetbrains.plugins.ruby.ruby.persistent.TypeInferenceDirectory
@@ -64,8 +63,6 @@ class ProjectLifecycleListenerImpl : ProjectManagerListener {
  projectName).toString() + DatabaseProvider.H2_DB_FILE_EXTENSION
 
  DatabaseProvider.connectToDB(filePath, isDefaultDatabase = true)
-
- DatabaseProvider.createAllDatabases()
  }
 
  /**

ide-plugin/src/test/java/org/jetbrains/plugins/ruby/ruby/actions/ImportExportTests.kt

@@ -20,7 +20,6 @@ class ImportExportTests : TestCase() {
 
  DatabaseProvider.connectToDB(generateTempDBFilePath(), isDefaultDatabase = true)
 
- DatabaseProvider.createAllDatabases(DatabaseProvider.defaultDatabase)
  DatabaseProvider.defaultDatabaseTransaction {
  data.forEach { CallInfoTable.insertInfoIfNotContains(it) }
  }
@@ -40,13 +39,10 @@ class ImportExportTests : TestCase() {
  }
 
  DatabaseProvider.connectToDB(generateTempDBFilePath(), isDefaultDatabase = true)
- DatabaseProvider.createAllDatabases(DatabaseProvider.defaultDatabase)
 
  val dbToImport = generateTempDBFilePath().let { pathToImport: String ->
  val db = DatabaseProvider.connectToDB(pathToImport)
 
- DatabaseProvider.createAllDatabases(db)
-
  transaction(db) {
  data.forEach { CallInfoTable.insertInfoIfNotContains(it) }
  }
@@ -74,16 +70,13 @@ class ImportExportTests : TestCase() {
  )
 
  DatabaseProvider.connectToDB(generateTempDBFilePath(), isDefaultDatabase = true)
- DatabaseProvider.createAllDatabases(DatabaseProvider.defaultDatabase)
  DatabaseProvider.defaultDatabaseTransaction {
  defaultDBData.forEach { CallInfoTable.insertInfoIfNotContains(it) }
  }
 
  val dbToImport = generateTempDBFilePath().let { pathToImport: String ->
  val db = DatabaseProvider.connectToDB(pathToImport)
 
- DatabaseProvider.createAllDatabases(db)
-
  transaction(db) {
  data.forEach { CallInfoTable.insertInfoIfNotContains(it) }
  }

signature-viewer/src/org/jetbrains/ruby/runtime/signature/SplitDB.kt

@@ -13,10 +13,7 @@ val gemToDBMap = HashMap<GemInfo?, Database>()
 fun gemToDB(info: GemInfo?, outputDir: String, rubyVersion: String): Database =
  gemToDBMap[info] ?: DatabaseProvider.connectToDB(Paths.get(outputDir,
  "${info?.name?.plus("-")?.plus(info.version) ?: "no_gem"}-ruby-$rubyVersion" + DatabaseProvider.H2_DB_FILE_EXTENSION).toString())
- .also {
- DatabaseProvider.createAllDatabases(it)
- gemToDBMap[info] = it
- }
+ .also { gemToDBMap[info] = it }
 
 fun input(msg: String): String {
  println(msg)

storage-server-api/src/main/java/org/jetbrains/ruby/codeInsight/types/storage/server/DatabaseProvider.kt

@@ -45,6 +45,7 @@ object DatabaseProvider {
  defaultDatabaseFilePath = filePath
  }
  logger.info("Connected to DB: $filePath")
+ createAllDatabases(database)
  logDatabaseSize(database)
  return database
  }