Skip to content

Commit c5d4651

Browse files
committed
Improve code style
1 parent 21662c3 commit c5d4651

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

JavaScript/2-imperative-good.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@
1111
const fs = require('fs');
1212

1313
const loadFile = (fileName) => {
14-
let data = null;
1514
try {
16-
data = fs.readFileSync(fileName, 'utf8');
15+
const data = fs.readFileSync(fileName, 'utf8');
16+
return data;
1717
} catch (error) {
1818
console.log('Can\'t read file: ' + fileName);
1919
}
20-
return data;
2120
};
2221

2322
const parseFile = (data) => {
@@ -27,12 +26,14 @@ const parseFile = (data) => {
2726
for (const line of lines) {
2827
if (line) {
2928
const cells = line.split(',');
30-
const name = cells[0];
31-
const population = parseInt(cells[1]);
32-
const area = parseInt(cells[2]);
33-
const density = parseInt(cells[3]);
34-
const country = cells[4];
35-
cities.push({ name, population, area, density, country });
29+
const [name, population, area, density, country] = cells;
30+
cities.push({
31+
name,
32+
population: parseInt(population),
33+
area: parseInt(area),
34+
density: parseInt(density),
35+
country,
36+
});
3637
}
3738
}
3839
return cities;

0 commit comments

Comments
 (0)