Use utf8 encoding if it isn't default

Author: tshemsedinov

JavaScript/1-imperative-bad.js

@@ -9,7 +9,7 @@
 
 const fs = require('fs');
 
-const data = fs.readFileSync('./cities.csv');
+const data = fs.readFileSync('./cities.csv', 'utf8');
 if (data) {
  const lines = data.toString().split('\n');
  lines.pop();

JavaScript/2-imperative-good.js

@@ -13,7 +13,7 @@ const fs = require('fs');
 function loadFile(fileName) {
  let data = null;
  try {
- data = fs.readFileSync(fileName);
+ data = fs.readFileSync(fileName, 'utf8');
  } catch (error) {
  console.log('Can\'t read file: ' + fileName);
  }

JavaScript/3-functional-bad.js

@@ -21,7 +21,7 @@ const width = [18, 10, 8, 8, 18, 6];
 let maxDensity = 0;
 
 const format = file => (
- fs.readFileSync(file).toString().split('\n')
+ fs.readFileSync(file, 'utf8').toString().split('\n')
  .filter((s, i) => i && s)
  .map(line => line.split(',').map((cell, i, arr) => (
  (i < 1 || i > 3) || (cell = parseInt(cell), arr[i] = cell),

JavaScript/4-functional-good.js

@@ -32,7 +32,7 @@ const calcProportion = table => calcColumn(table, table[0][densityCol()]);
 
 const parseTable = lines => lines.map(line => line.split(','));
 const toLines = data => data.split('\n').filter((s, i) => i && s);
-const readFile = file => fs.readFileSync(file).toString();
+const readFile = file => fs.readFileSync(file, 'utf8').toString();
 const getDataset = compose(readFile, toLines, parseTable);
 
 const main = compose(getDataset, sortByDensity, calcProportion, renderTable);

JavaScript/5-functional-alternative.js

@@ -23,7 +23,7 @@ const calcProportion = table => (
  ))
 );
 
-const getDataset = file => fs.readFileSync(file).toString()
+const getDataset = file => fs.readFileSync(file, 'utf8').toString()
  .split('\n')
  .filter((s, i) => i && s)
  .map(line => line.split(','));

JavaScript/6-functional-pure.js

@@ -63,7 +63,7 @@ const toLines = pipe(
  filter(hasValue)
 );
 
-const readFile = file => fs.readFileSync(file).toString();
+const readFile = file => fs.readFileSync(file, 'utf8').toString();
 
 const getDataset = pipe(
  readFile,

JavaScript/7-mixed.js

@@ -28,7 +28,7 @@ const calcProportion = (table) => {
 };
 
 const getDataset = (file) => {
- const lines = fs.readFileSync(file).toString().split('\n');
+ const lines = fs.readFileSync(file, 'utf8').toString().split('\n');
  lines.shift();
  lines.pop();
  return lines.map(line => line.split(','));