Skip to content

Conversation

@Potherca
Copy link
Member

Fixes #129

@Potherca
Copy link
Member Author

@jrfnl I finally found some time to update this! 🎉

I've changed the wording, as you suggested. Some things to note:

  • I added links to various things, just in case people want to know more
  • I placed the comment in a block (using >) to make it similar to the warning block further down in the document
  • I added an emoji as icon for the block, to make it stand out more (and look similar to the other block). I didn't feel this message warranted a "warning", so I opted for "Information" instead.
@Potherca Potherca requested a review from jrfnl June 13, 2021 11:13

This plugin is compatible with:

- PHP **5.x**, **7.x**, and **8.x** (Support for PHP v8 is available since [`v0.7.0`][v0.7])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just placing a note here for the record:
While we currently can only guarantee support with PHP 8.0, the current test build against PHP 8.1 does seem to pass, so I'm fine with leaving this at v8.

@jrfnl jrfnl merged commit ce4370e into PHPCSStandards:master Jun 13, 2021
@Potherca Potherca deleted the issues/129-compatibility branch June 14, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants