Skip to content

Commit 132ef86

Browse files
committed
Removed all hardcoded strings,somewhat performance improvements
1 parent 67de983 commit 132ef86

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

app/src/main/res/layout/fragment_home.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@
5353
android:layout_width="match_parent"
5454
android:layout_height="wrap_content"
5555
android:shadowColor="@color/colorPrimary"
56-
android:text="Highlights"
56+
android:text="@string/highlights"
5757
android:textAlignment="center"
5858
android:textAllCaps="true"
5959
android:textColor="#ffff"
60-
android:textSize="25dip"
60+
android:textSize="25sp"
6161
android:textStyle="bold" />
6262

6363
</LinearLayout>
@@ -81,7 +81,7 @@
8181
<TextView
8282
android:layout_width="match_parent"
8383
android:layout_height="wrap_content"
84-
android:text="STUFF TO BE ADDED LATER"
84+
android:text="@string/stuff_to_be_added_later"
8585
android:textAllCaps="true"
8686
android:textStyle="bold"
8787
android:textSize="25dip"
@@ -109,7 +109,7 @@
109109
<TextView
110110
android:layout_width="match_parent"
111111
android:layout_height="wrap_content"
112-
android:text="About Us"
112+
android:text="@string/about_us"
113113
android:textStyle="bold"
114114
android:textColor="#ffff"
115115
android:textAlignment="center"

app/src/main/res/layout/popup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
android:layout_width="match_parent"
2323
android:layout_height="wrap_content"
2424
android:textSize="22dip"
25-
android:text="CLOSE"
25+
android:text="@string/close"
2626
android:id="@+id/pcbutton"/>
2727

2828

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,8 @@
2020
<string name="permission_rationale">"Contacts permissions are needed for providing email
2121
completions."
2222
</string>
23+
<string name="highlights">Highlights</string>
24+
<string name="stuff_to_be_added_later">STUFF TO BE ADDED LATER</string>
25+
<string name="about_us">About Us</string>
26+
<string name="close">CLOSE</string>
2327
</resources>

0 commit comments

Comments
 (0)