Skip to content

add the missing headers in windows #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add the missing headers in windows #1482

wants to merge 4 commits into from

Conversation

@flutter-painter
Copy link

@flutter-painter flutter-painter commented Jul 8, 2025 •
edited
Loading

Fixed the windows compatibility issue

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main. -> rebase what ?
  • I added new tests to check the change I am making, or this PR does not need tests.
    -> No need, here we simply fix the bloody thing
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.
@flutter-painter
Copy link
Author

flutter-painter commented Jul 8, 2025

Hi @ened
Could you please review ?
@flutter-painter
Added: permission_handler_windows/windows/include/permission_handler/…
9ee53b9 
…permission_handler_plugin.h (compatibility header) Updated: permission_handler_windows/windows/CMakeLists.txt (added compatibility header to build)
@flutter-painter
cleaner
e4029c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@flutter-painter