Skip to content

Commit 7e3aeb2

Browse files
authored
Linting changes (#35)
1 parent e0abf33 commit 7e3aeb2

File tree

8 files changed

+31
-31
lines changed

8 files changed

+31
-31
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ Most Azure resources deployed in the prior steps will incur ongoing charges unle
240240
az group delete -n $RESOURCE_GROUP -y
241241

242242
# Purge the soft delete resources
243-
az keyvault purge -n kv-${BASE_NAME} -l $LOCATION
243+
az keyvault purge -n kv-${BASE_NAME} -l $LOCATION
244244
az cognitiveservices account purge -g $RESOURCE_GROUP -l $LOCATION -n oai-${BASE_NAME}
245245
```
246246

SECURITY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Instead, please report them to the Microsoft Security Response Center (MSRC) at
1414

1515
If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://aka.ms/security.md/msrc/pgp).
1616

17-
You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).
17+
You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).
1818

1919
Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue:
2020

infra-as-code/bicep/acr.bicep

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ resource acrResourceDiagSettings 'Microsoft.Insights/diagnosticSettings@2021-05-
5151
properties: {
5252
workspaceId: logWorkspace.id
5353
logs: [
54-
{
55-
categoryGroup: 'allLogs'
56-
enabled: true
57-
retentionPolicy: {
58-
enabled: false
59-
days: 0
60-
}
54+
{
55+
categoryGroup: 'allLogs'
56+
enabled: true
57+
retentionPolicy: {
58+
enabled: false
59+
days: 0
6160
}
61+
}
6262
]
6363
logAnalyticsDestinationType: null
6464
}

infra-as-code/bicep/keyvault.bicep

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ resource keyVault 'Microsoft.KeyVault/vaults@2019-09-01' = {
3636

3737
tenantId: subscription().tenantId
3838

39-
enableRbacAuthorization: true // Using RBAC
40-
enabledForDeployment: true // VMs can retrieve certificates
41-
enabledForTemplateDeployment: true // ARM can retrieve values
39+
enableRbacAuthorization: true // Using RBAC
40+
enabledForDeployment: true // VMs can retrieve certificates
41+
enabledForTemplateDeployment: true // ARM can retrieve values
4242

4343
enableSoftDelete: true
4444
softDeleteRetentionInDays: 7
45-
createMode: 'default' // Creating or updating the key vault (not recovering)
45+
createMode: 'default' // Creating or updating the key vault (not recovering)
4646
}
4747
}
4848

@@ -53,14 +53,14 @@ resource keyVaultDiagSettings 'Microsoft.Insights/diagnosticSettings@2021-05-01-
5353
properties: {
5454
workspaceId: logWorkspace.id
5555
logs: [
56-
{
57-
categoryGroup: 'allLogs'
58-
enabled: true
59-
retentionPolicy: {
60-
enabled: false
61-
days: 0
62-
}
56+
{
57+
categoryGroup: 'allLogs'
58+
enabled: true
59+
retentionPolicy: {
60+
enabled: false
61+
days: 0
6362
}
63+
}
6464
]
6565
logAnalyticsDestinationType: null
6666
}

infra-as-code/bicep/machinelearning.bicep

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ param baseName string
1010
@description('The resource group location')
1111
param location string = resourceGroup().location
1212

13-
// existing resource name params
13+
// existing resource name params
1414
param applicationInsightsName string
1515
param containerRegistryName string
1616
param keyVaultName string
@@ -153,17 +153,17 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview'
153153
tier: 'Basic'
154154
}
155155
identity: {
156-
type: 'SystemAssigned' // This resource's identity is automatically assigned priviledge access to ACR, Storage, Key Vault, and Application Insights.
156+
type: 'SystemAssigned' // This resource's identity is automatically assigned priviledge access to ACR, Storage, Key Vault, and Application Insights.
157157
}
158158
properties: {
159159
friendlyName: 'Azure OpenAI Chat Hub'
160160
description: 'Hub to support the Microsoft Learn Azure OpenAI basic chat implementation. https://learn.microsoft.com/azure/architecture/ai-ml/architecture/basic-openai-e2e-chat'
161-
publicNetworkAccess: 'Enabled' // Production readiness change: The "Baseline" architecture adds ingress and egress network control over this "Basic" implementation.
161+
publicNetworkAccess: 'Enabled' // Production readiness change: The "Baseline" architecture adds ingress and egress network control over this "Basic" implementation.
162162
ipAllowlist: []
163163
serverlessComputeSettings: null
164164
enableServiceSideCMKEncryption: false
165165
managedNetwork: {
166-
isolationMode: 'Disabled' // Production readiness change: The "Baseline" architecture adds ingress and egress network control over this "Basic" implementation.
166+
isolationMode: 'Disabled' // Production readiness change: The "Baseline" architecture adds ingress and egress network control over this "Basic" implementation.
167167
}
168168
allowRoleAssignmentOnRG: false // Require role assignments at the resource level.
169169
v1LegacyMode: false
@@ -221,7 +221,7 @@ resource aiHubDiagSettings 'Microsoft.Insights/diagnosticSettings@2021-05-01-pre
221221
}
222222

223223
// ---- Chat project ----
224-
224+
225225
@description('This is a container for the chat project.')
226226
resource chatProject 'Microsoft.MachineLearningServices/workspaces@2024-04-01' = {
227227
name: 'aiproj-chat'
@@ -232,7 +232,7 @@ resource chatProject 'Microsoft.MachineLearningServices/workspaces@2024-04-01' =
232232
tier: 'Basic'
233233
}
234234
identity: {
235-
type: 'SystemAssigned' // This resource's identity is automatically assigned priviledge access to ACR, Storage, Key Vault, and Application Insights.
235+
type: 'SystemAssigned' // This resource's identity is automatically assigned priviledge access to ACR, Storage, Key Vault, and Application Insights.
236236
}
237237
properties: {
238238
friendlyName: 'Chat with Wikipedia project'
@@ -293,7 +293,7 @@ resource chatProjectDiagSettings 'Microsoft.Insights/diagnosticSettings@2021-05-
293293
workspaceId: logWorkspace.id
294294
logs: [
295295
{
296-
categoryGroup: 'allLogs' // Production readiness change: In production, this is probably excessive. Please tune to just the log streams that add value to your workload's operations.
296+
categoryGroup: 'allLogs' // Production readiness change: In production, this is probably excessive. Please tune to just the log streams that add value to your workload's operations.
297297
enabled: true
298298
retentionPolicy: {
299299
enabled: false

infra-as-code/bicep/modules/keyvaultRoleAssignment.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/*
22
This template creates a role assignment for a managed identity to access secrets in key vault.
33
4-
To ensure that each deployment has a unique role assignment ID, you can use the guid() function with a seed value that is based in part on the
5-
managed identity's principal ID. However, because Azure Resource Manager requires each resource's name to be available at the beginning of the deployment,
4+
To ensure that each deployment has a unique role assignment ID, you can use the guid() function with a seed value that is based in part on the
5+
managed identity's principal ID. However, because Azure Resource Manager requires each resource's name to be available at the beginning of the deployment,
66
you can't use this approach in the same Bicep file that defines the managed identity. This sample uses a Bicep module to work around this issue.
77
*/
88
@description('The Id of the role definition.')

infra-as-code/bicep/openai.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ resource openAiAccount 'Microsoft.CognitiveServices/accounts@2023-10-01-preview'
2222
kind: 'OpenAI'
2323
properties: {
2424
customSubDomainName: 'oai-${baseName}'
25-
publicNetworkAccess: 'Enabled' // Production readiness change: This sample uses identity as the perimeter. Production scenarios should layer in network perimeter control as well.
25+
publicNetworkAccess: 'Enabled' // Production readiness change: This sample uses identity as the perimeter. Production scenarios should layer in network perimeter control as well.
2626
disableLocalAuth: true
2727
}
2828
sku: {

infra-as-code/bicep/webapp.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ resource logWorkspace 'Microsoft.OperationalInsights/workspaces@2022-10-01' exis
2323
name: logWorkspaceName
2424
}
2525

26-
// Built-in Azure RBAC role that is applied to a Key Vault to grant secrets content read permissions.
26+
// Built-in Azure RBAC role that is applied to a Key Vault to grant secrets content read permissions.
2727
resource keyVaultSecretsUserRole 'Microsoft.Authorization/roleDefinitions@2022-04-01' existing = {
2828
name: '4633458b-17de-408a-b874-0445c86b69e6'
2929
scope: subscription()

0 commit comments

Comments
 (0)