ref(tracing): Clean up various things before fixing sampling #2944
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Extracted from #2921, to try to make it less of an unwieldy mess. Random refactoring of stuff - mostly tests - not directly related to those changes, but which came as a consequence of working on that.
I believe the only minorly substantive changes are:
beforeNavigatewhich did nothing (in order that the option be able to be required), which I removed in favor of letting the option be optional and only runningbeforeNavigateif it's defined.Responsetype since it's a dom type and not everyone compiles with those.There's a bunch here, but I did my best to keep my commits clean* so it would be possible to look at each one individually and make sure I'm not doing anything nuts or breaking.
*only about one thing, named appropriately, with passing tests at each stage