Skip to content

Conversation

@lobsterkatie
Copy link
Member

Extracted from #2921, to try to make it less of an unwieldy mess. Random refactoring of stuff - mostly tests - not directly related to those changes, but which came as a consequence of working on that.

I believe the only minorly substantive changes are:

  • We had a default beforeNavigate which did nothing (in order that the option be able to be required), which I removed in favor of letting the option be optional and only running beforeNavigate if it's defined.
  • I removed the Response type since it's a dom type and not everyone compiles with those.
  • For XHR requests, the method and url are now added to the span when it's created rather than when it's finished, for consistency with fetch requests.

There's a bunch here, but I did my best to keep my commits clean* so it would be possible to look at each one individually and make sure I'm not doing anything nuts or breaking.

*only about one thing, named appropriately, with passing tests at each stage

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 18.01 KB (+0.01% 🔺)
@sentry/browser - Webpack 18.82 KB (0%)
@sentry/react - Webpack 18.82 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 23.81 KB (-0.03% 🔽)
@lobsterkatie lobsterkatie force-pushed the kmclb-pre-sampling-fixes-cleanup branch from 77425d6 to 58f7f3f Compare September 30, 2020 00:15
@kamilogorek
Copy link
Contributor

It'll fix #2943 as well

@lobsterkatie lobsterkatie merged commit 0ee0799 into master Sep 30, 2020
@lobsterkatie lobsterkatie deleted the kmclb-pre-sampling-fixes-cleanup branch September 30, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants