Cover more cases for symbol refs finder (resolves #1273)

Author: webpro

packages/knip/fixtures/ignore-exports-used-in-file-shorthand/src/fn.js

@@ -0,0 +1,3 @@
+export function fn() {}
+
+const obj = { fn };

packages/knip/fixtures/ignore-exports-used-in-file-shorthand/src/index.js

@@ -1,4 +1,5 @@
 import './antecedents';
+import './fn';
 import { slice } from './slice';
 
 slice;

packages/knip/src/typescript/find-internal-references.ts

@@ -54,7 +54,8 @@ export const findInternalReferences = (
  if (declaration) {
  // @ts-expect-error Keep it cheap
  if (findInFlow(declaration.name?.flowNode, item.symbol)) {
- return [++refCount, isSymbolInExport];
+ refCount++;
+ return [refCount, isSymbolInExport];
  }
 
  if (ts.isImportSpecifier(declaration) && symbols.has(symbol)) {
@@ -63,6 +64,14 @@ export const findInternalReferences = (
  }
  }
 
+ if (symbol && symbol.flags & ts.SymbolFlags.Property) {
+ const type = typeChecker.getTypeOfSymbol(symbol);
+ if (type?.symbol && item.symbol === type.symbol) {
+ refCount++;
+ if (isBindingElement) return [refCount, isSymbolInExport];
+ }
+ }
+
  symbols.add(symbol);
  }
  }

packages/knip/test/ignore-exports-used-in-file-shorthand.test.ts

@@ -13,7 +13,7 @@ test('Find unused exports respecting an ignoreExportsUsedInFile (shorthand)', as
 
  assert.deepEqual(counters, {
  ...baseCounters,
- processed: 3,
- total: 3,
+ processed: 4,
+ total: 4,
  });
 });