Skip to content

Conversation

@hai-x
Copy link
Member

@hai-x hai-x commented Jul 3, 2025

What kind of change does this PR introduce?

Refactor logic. !this._redirectTo !== undefined always return true.

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@hai-x hai-x marked this pull request as ready for review July 3, 2025 15:51
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Performance Report

Merging #19655 will degrade performances by 81.22%

Comparing refactor-logic (1ae4b36) with main (a113022)

Summary

⚡ 82 improvements
❌ 2 regressions
✅ 49 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 227.4 ms 14.1 ms ×16
benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 12.1 ms 52.5 ms -76.92%
benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.2 ms 50.2 ms +21.94%
benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 9.8 ms 52.1 ms -81.22%
benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 30.8 ms 24.1 ms +27.48%
md4 buffer benchmark (size: 10000) 114.2 µs 72.8 µs +56.87%
md4 buffer benchmark (size: 100000) 447.8 µs 406.5 µs +10.16%
md4 buffer benchmark (size: 120) 76.2 µs 34.7 µs ×2.2
md4 buffer benchmark (size: 160) 76.3 µs 34.8 µs ×2.2
md4 buffer benchmark (size: 16366) 138.6 µs 97.2 µs +42.56%
md4 buffer benchmark (size: 16368) 138.6 µs 97.3 µs +42.53%
md4 buffer benchmark (size: 16370) 138.8 µs 97.2 µs +42.72%
md4 buffer benchmark (size: 2) 76.4 µs 34.8 µs ×2.2
md4 buffer benchmark (size: 20) 76.3 µs 32.4 µs ×2.4
md4 buffer benchmark (size: 200) 76.5 µs 35 µs ×2.2
md4 buffer benchmark (size: 2000) 82.1 µs 40.6 µs ×2
md4 buffer benchmark (size: 20000) 152.7 µs 111.4 µs +37.13%
md4 buffer benchmark (size: 2002) 82 µs 40.6 µs ×2
md4 buffer benchmark (size: 40) 73.6 µs 32.4 µs ×2.3
md4 buffer benchmark (size: 400) 77.2 µs 35.7 µs ×2.2
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit 8ccc7da into main Jul 8, 2025
40 of 44 checks passed
@alexander-akait alexander-akait deleted the refactor-logic branch July 8, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants