fix: make webpack optional peer dependency

[hardfist]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

No, not easy to test in this repo

Motivation / Use-Case

fixes #4776

Breaking Changes

No

Additional Info

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hardfist / name: hardfist (bea6143)

[snitin315]

You may also want to remove it from the peerDependenciesfield above

webpack-dev-server/package.json

Line 137 in 4e84607

"webpack": "^4.37.0 || ^5.0.0"

[hardfist]

if we remove webpack from peerDependencies it would mean any webpack version would be ok for webpack-dev-server but webpack-dev-server did require specific webpack version according to the documentation of https://pnpm.io/next/package_json#peerdependenciesmetaoptional

[alexander-akait]

Yeah, we still need versions, in theory this PR can break a code for some inattentive developers (which ignored warnings from package managers), if you don't have webpack in dependcies and rely on the new behaviour of npm (autoinstall peer deps), but it should be fixed on their side, because you should always list of you dependecies

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e84607) 92.05% compared to head (bea6143) 92.05%.

Additional details and impacted files

@@ Coverage Diff @@ ## master #4778 +/- ## ======================================= Coverage 92.05% 92.05% ======================================= Files 16 16 Lines 1662 1662 Branches 622 622 ======================================= Hits 1530 1530 Misses 121 121 Partials 11 11 

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.