fix(server): don't crash on setupExitSignals(undefined) #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Not sure how it's possible as all callers pass an object, but observed in webpack#1479 (comment)
cben requested review from alexander-akait, hiroppy and knagaitsev as code owners 
|
|
Codecov Report
@@ Coverage Diff @@ ## master #2507 +/- ## ======================================= Coverage 93.58% 93.58% ======================================= Files 34 34 Lines 1325 1325 Branches 381 381 ======================================= Hits 1240 1240 Misses 83 83 Partials 2 2
Continue to review full report at Codecov.
|
| I may be wrong but CI failures seem unrelated? |
alexander-akait approved these changes Apr 7, 2020
| Restart CI, we will stability them in near future /cc @hiroppy |
hiroppy approved these changes Apr 8, 2020
| @cben Good work with the test |
jeffin143 approved these changes Apr 8, 2020
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes.
Motivation / Use-Case
Someone observed this line crash:
#1479 (comment)
This is the fix suggested by @evilebottnawi — please review.
Breaking Changes
none.
Additional Info
I don't see how that crash was possible, all callers (1 real + few tests) pass an object (and weren't touched since #2181 introduced
serverData. But I also can't argue with a stacktrace :-)Feel free to reject.