Skip to content

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

feature

Summary
webpack-dev-middleware have option reportTime, but i can't setup this option using webpack-dev-server

Does this PR introduce a breaking change?

No

Other information

No

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #1209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1209 +/- ## ======================================= Coverage 76.31% 76.31% ======================================= Files 5 5 Lines 477 477 Branches 154 154 ======================================= Hits 364 364 Misses 113 113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c3ceb...4e56847. Read the comment docs.

@shellscape
Copy link
Contributor

@evilebottnawi v3 is leveraging loglevel https://github.com/webpack/webpack-dev-server/blob/next/lib/log.js, and output from that should follow the same option, otherwise we'll get unbalanced expectations for log output. that means we need to update webpack-dev-middleware (which I am planning on doing soon) to use the same patterns. going that route, we should introduce the ability for users to provide their own log prefix, rather than granular options.

@shellscape
Copy link
Contributor

@evilebottnawi We can merge this as 2.x of WDS is still using 1.x of WDM and 1.x has this older option.

Note: v2 of webpack-dev-middleware was released and removed reportTime in favor of logTime. v3 of webpack-dev-server supports the same option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants