enable progress from config #1181
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #1181 +/- ## ======================================= Coverage 76.31% 76.31% ======================================= Files 5 5 Lines 477 477 Branches 154 154 ======================================= Hits 364 364 Misses 113 113Continue to review full report at Codecov.
|
| throw e; | ||
| } | ||
| | ||
| if (argv.progress) { |
There was a problem hiding this comment.
a less impactful option would have been to set options.progress within the existing if block. keep an eye on those kinds of simple changes in the future and give them favor.
There was a problem hiding this comment.
I think I understand what you're saying, since the progress opt is only used here and its not always common to use, it would have been less impactful to set the progress opt inside of the if block so it wouldn't be assigned on every run?
Thank you for the review! Looking forward to the v3 version :)
| @ryanwholey (copied from your related PR) thanks for the PR! we love getting new tests submitted and normally would be quick to add them to the repo. right now we're in a holding pattern on new code and new features while we prep v3 on the beta branch. While we're not looking for outside contributions on that branch at the moment, we will be in the near future. we're going to have to put this PR on hold for a bit, but we'll be circling back to it. |
| Thanks for your patience @ryanwholey and your contributions. We've merged your two PRs. |
| nice!!!!! thanks team, happy holidays! |
3 participants
Enables progress option to be read from the passed config (in addition to the command line)
What kind of change does this PR introduce?
Extends current feature by allowing option to be read from webpack config
Did you add or update the
examples/?The example passed progress in its config already, so it wasnt working properly. It now works as expected.
Summary
I was working on another project which uses webpack dev server heavily. I like the progress option because it gives the user some feedback. On a code review, someone recommended to clean up my package.json I should move the --progress options to the config since I pass it to each webpack-dev-server script. Turned out it was CLI only!
Does this PR introduce a breaking change?
No it should not!
Other information
Very excited to contribute! I really love webpack dev server and I hope I get the opportunity to contribute more in the future.