fix: skip content-type header on unknown types #809
Merged
+32 −67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes webpack#354 * Only set 'Content-Type' header if mime type is known. * Remove testing for 'Content-Type' of unknown types. * Do not test against `application/octet-stream'. Unknown media types should have content-type blank. Because frameworks handle Content-Types differently, it is not possible to standardize testing at the moment. Tests against `application/octet-stream` can create false positives with Express because of this. https://tools.ietf.org/html/rfc7231#section-3.1.1.5 broofa/mime#139
Codecov Report
@@ Coverage Diff @@ ## master #809 +/- ## ======================================= Coverage 99.22% 99.22% ======================================= Files 10 10 Lines 259 259 Branches 83 83 ======================================= Hits 257 257 Misses 2 2
Continue to review full report at Codecov.
|
alexander-akait approved these changes Jan 3, 2021
Member
| Big thanks for the work |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #354
Unknown media types should have content-type blank. Because
frameworks handle Content-Types differently, it is not possible to
standardize testing at the moment. Tests against
application/octet-streamcan create false positives with Expressbecause of this.
https://tools.ietf.org/html/rfc7231#section-3.1.1.5
broofa/mime#139
This PR contains a:
Motivation / Use-Case
Breaking Changes
Unknown mime types (no extension or unknown extension) no longer produce a
Content-Typewith Connect/NodeJS API.Additional Info
https://tools.ietf.org/html/rfc7231#section-3.1.1.5
broofa/mime#139