fix: directly used mkdirp instead of through Webpack #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes Webpack 5 usage by no longer requiring the removed webpack/lib/node/NodeOutputFileSystem
19 tasks
hiroppy approved these changes Jul 8, 2019
Member
| Thanks. |
| When will a new release be cut? |
| Could we please have a release to benefit from this update and use it again with latest versions of webpack 5? |
Member
| In TODO, release will be tomorrow |
| Great, thanks @evilebottnawi |
| Any word on releasing this? |
Member
| @natew yes, today, we find some problems with api and redesigning it in the next version, so it took us a little longer |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes Webpack 5 usage by no longer requiring the removed webpack/lib/node/NodeOutputFileSystem
This PR contains a:
Motivation / Use-Case
Fixes #435.
Breaking Changes
Introduces dependency on
mkdirp, which was only transient throughwebpackbefore.