chore: bump Rsbuild 1.6.0-beta.1 and remove special output.distPath merge logic #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tPath` merge logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps @rsbuild/core from version 1.6.0-beta.0 to 1.6.0-beta.1 across the monorepo and removes special merge logic for output.distPath that is no longer needed.
Key changes:
- Updated @rsbuild/core dependency from 1.6.0-beta.0 to 1.6.0-beta.1 across all package.json files
- Removed conversion logic that transformed string
output.distPathto object format in config.ts - Updated test snapshots to reflect changes in Rsbuild's default configuration behavior
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Removed special output.distPath string-to-object conversion logic |
| packages/core/package.json | Updated @rsbuild/core to 1.6.0-beta.1 |
| packages/core/tests/snapshots/config.test.ts.snap | Updated snapshot to reflect config ordering and experimental feature changes |
| tests/integration/preserve-jsx/snapshots/index.test.ts.snap | Updated snapshot for webpack runtime changes |
| Multiple package.json files | Bumped @rsbuild/core dependency to 1.6.0-beta.1 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework approved these changes Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
output.distPathmerge logic introduced in fix: mergeoutput.distPathcorrectly #1270 since Rsbuild ensure to merge correctly in fix: ensureoutput.distPathcan be merged correctly rsbuild#6369Related Links
Checklist