Skip to content

Conversation

nieyuyao
Copy link
Contributor

fix #5002

the issue seems to only occur when HybridMode is turned off.

the enabledHbridMode variable is initialized to true, but was not updated to the correct value before patching vscode.typescript-language-features.

export const enabledHybridMode = ref<boolean>(true);

if (!enabledTypeScriptPlugin.value) {
text = text.replace(
'for(const e of n.contributes.typescriptServerPlugins',
s => s + `.filter(p=>p.name!=='vue-typescript-plugin-pack')`
);

so, both tsserver and vue language server will respond to completions, and they are duplicated.

Copy link

pkg-pr-new bot commented Nov 23, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5019 

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5019 

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5019 

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5019 

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5019 

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5019 

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5019 

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5019 

commit: d8805d1

@nieyuyao nieyuyao requested a review from KazariEX December 7, 2024 05:12
@KazariEX KazariEX changed the title fix(hybridMode): update enabledHybridMode before activate extension fix(vscode): update enabledHybridMode before activate extension Dec 7, 2024
@KazariEX KazariEX merged commit dc90036 into vuejs:master Dec 7, 2024
5 checks passed
@nieyuyao nieyuyao deleted the fix/duplicate-completions branch December 9, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants