Skip to content

Conversation

rioj7
Copy link
Contributor

@rioj7 rioj7 commented Nov 13, 2024

The current marketplace page is broken.

Cause adding literal html tags (script, template, style)

Vue: Split <script>, <template>, <style> Editors 

If put inside code ticks they are no longer interpreted as html tags.

Vue: Split `<script>`, `<template>`, `<style>` Editors 

Fix settings table by replacing the | character in an example by its HTML entity equivalent. (needs to use html code tags)

Auto add space between double curly brackets: <code>{{&vert;}}</code> -> <code>{{ &vert; }}</code> 
Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5004 

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5004 

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5004 

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5004 

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5004 

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5004 

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5004 

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5004 

commit: cd973dd

@kermanx
Copy link
Collaborator

kermanx commented Nov 14, 2024

Hmmm, this part of README is auto-generated by https://github.com/antfu/vscode-ext-gen, thus it will be overwritten to the old one on the next build. We can't just edit it. Instead, we should either:

@rioj7
Copy link
Contributor Author

rioj7 commented Dec 19, 2024

@kermanx @KazariEX https://github.com/antfu/vscode-ext-gen v0.5.3 now has a Markdown Escape for text extracted from the package.json file

@KazariEX
Copy link
Member

Could you please update the deps and readme?

@rioj7
Copy link
Contributor Author

rioj7 commented Dec 20, 2024

@KazariEX

Looking at the README Blame I see that github-actions[bot] has added a commit 2 days ago 74a1918 ci(lint): auto-fix that partially modified the effected lines. It has changed 1 | and 1 <> pair. But not all.

I made a small mistake in the vscode-ext-gen pull request. I have submitted a fix pull request.

It looks like the github actions fetch the latest v0.5.x vscode-ext-gen so no modification of package.json is needed.

According to KermanX that part of README is generated/replaced at each release build.

@johnsoncodehk johnsoncodehk merged commit a161283 into vuejs:master Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants