Skip to content

fix(language-core): handle v-for with v-once correctly #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix(language-core): handle v-for with v-once correctly #4830

merged 4 commits into from
Sep 10, 2024

Conversation

KazariEX
Copy link
Member

@KazariEX KazariEX commented Sep 9, 2024

fix #4827
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 9, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4830

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4830

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4830

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4830

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4830

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4830

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4830

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4830

commit: e1f09d6
@KazariEX KazariEX enabled auto-merge (squash) September 9, 2024 12:06
kermanx
kermanx previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@kermanx kermanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the code in fact 😜 Just a test?
johnsoncodehk
johnsoncodehk reviewed Sep 9, 2024
View reviewed changes
@KazariEX @johnsoncodehk
Update packages/language-core/lib/codegen/template/vFor.ts
b8f16aa 
Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
kermanx
kermanx previously approved these changes Sep 9, 2024
View reviewed changes
zhiyuanzmj
zhiyuanzmj approved these changes Sep 10, 2024
View reviewed changes
@KazariEX KazariEX requested a review from kermanx September 10, 2024 03:35
@KazariEX KazariEX merged commit 814b30f into vuejs:master Sep 10, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/issue-4827 branch September 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@KazariEX @johnsoncodehk @zhiyuanzmj @kermanx