fix: should only use context.physicalFilename as fallback instead of main source (#399)

Author: JounQin

.changeset/itchy-poets-rush.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix: should only use `context.physicalFilename` as fallback instead of main source

src/utils/import-type.ts

@@ -283,7 +283,7 @@ function isInternalPath(
  * @param name The name of the module to check
  * @returns `true` if the name is an external looking name, otherwise `false`
  */
-function isExternalLookingName(name: string) {
+export function isExternalLookingName(name: string) {
  return isModule(name) || isScoped(name)
 }
 

src/utils/resolve.ts

@@ -19,6 +19,7 @@ import type {
 
 import { arraify } from './arraify.js'
 import { makeContextCacheKey } from './export-map.js'
+import { isExternalLookingName } from './import-type.js'
 import {
  LEGACY_NODE_RESOLVERS,
  normalizeConfigResolvers,
@@ -304,9 +305,11 @@ function fullResolve(
  } // backward compatibility
 
  const sourceFiles =
- context.physicalFilename === sourceFile
+ context.physicalFilename === sourceFile ||
+ // only try to fallback for external packages
+ !isExternalLookingName(modulePath)
  ? [sourceFile]
- : [context.physicalFilename, sourceFile]
+ : [sourceFile, context.physicalFilename]
 
  for (const sourceFile of sourceFiles) {
  for (const {
@@ -355,7 +358,7 @@ function fullResolve(
  }
 
  // else, counts
- fileExistsCache.set(cacheKey, resolved.path as string | null)
+ fileExistsCache.set(cacheKey, resolved.path)
  return resolved
  }
  }

test/fixtures/config-helper.js

@@ -6,17 +6,19 @@ import { setTimeout } from 'node:timers/promises'
 import { jest } from '@jest/globals'
 import type { TSESLint } from '@typescript-eslint/utils'
 
-import { testContext, testFilePath } from '../utils.js'
+import { TEST_FILENAME, testContext, testFilePath } from '../utils.js'
 
-import { importXResolverCompat } from 'eslint-plugin-import-x'
+import { cjsRequire, importXResolverCompat } from 'eslint-plugin-import-x'
 import type {
  CjsRequire,
  NewResolver,
  NormalizedCacheSettings,
+ RuleContext,
 } from 'eslint-plugin-import-x'
 import {
  CASE_SENSITIVE_FS,
  fileExistsWithCaseSync,
+ relative,
  resolve,
 } from 'eslint-plugin-import-x/utils'
 
@@ -830,5 +832,15 @@ describe('resolve', () => {
  }),
  ).toBe(testFilePath('./bar.tsx'))
  })
+
+ it('sourceFile should take higher priority than context.physicalFilename', () => {
+ const sourceFile = cjsRequire.resolve('typescript-eslint')
+ expect(
+ relative('./config-helper', sourceFile, {}, {
+ physicalFilename: TEST_FILENAME,
+ settings: {},
+ } as RuleContext),
+ ).toBe(path.resolve(sourceFile, '../config-helper.js'))
+ })
  })
 })