fix(vite): set ssr.noExternal
even if not in project package.json #404
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If
@testing-library/svelte
is not set in thepackage.json
of the project Vitest is running in (e.g. in certain monorepo setups),@sveltejs/vite-plugin-svelte
will not detect that it needs to be inlined. This, in turn, breaks Svelte 5 support, which relies on STL running through the Svelte compiler for runes support.Hopefully this is something that can be fixed in
@sveltejs/vite-plugin-svelte
, but it might not be! This PR updates our own Vite plugin to ensure this setting is correct, even if@sveltejs/vite-plugin-svelte
misses it.Fixes #403