Pass GitHub access token when accessing raw.githubusercontent.com in case of private recipes #842
+5 −0
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm checking how to use private symfony recipes and found that
symfony/flexis not using GH access token when accessingraw.githubcontent.com.For a public repositories it's not a case, but for private repositories it's not possible to access the recipe template url from
raw.githubcontent.comwithout using access token.Adding access token for requests to
api.github.comis covered by Composer, but it doesn't cover downloading files fromraw.githubcontent.com.This PR introduces logic for adding token for requests to
raw.githubcontent.comin the similar way as composer does forapi.github.com.Limitations:
raw.githubusercontent.com, but I don't think that it's a big issue actually.