Skip to content

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 9, 2025

Description:

This feature would be helpful for rspack/Deno/next.js folks because they always use external helpers. I didn't list up other ones because I don't know their details.

BREAKING CHANGE:

This PR introduces a breaking change for Rust API because external: false will not have an impact anymore if the inline-helpers feature is disabled

@kdy1 kdy1 added this to the Planned milestone Jul 9, 2025
@kdy1 kdy1 self-assigned this Jul 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: 592ad29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 9, 2025

CodSpeed Performance Report

Merging #10808 will improve performances by 2.24%

Comparing kdy1/size (592ad29) with main (406433d)

Summary

⚡ 1 improvements
✅ 139 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/resolver_with_hygiene/typescript 807.6 ms 789.9 ms +2.24%
@kdy1 kdy1 marked this pull request as ready for review July 9, 2025 03:55
@kdy1 kdy1 requested a review from a team as a code owner July 9, 2025 03:55
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 9, 2025
@kdy1 kdy1 requested a review from a team as a code owner July 9, 2025 03:55
@kdy1 kdy1 enabled auto-merge (squash) July 9, 2025 03:57
@kdy1 kdy1 changed the base branch from dev/rust to main July 10, 2025 15:46
@kdy1 kdy1 dismissed kodiakhq[bot]’s stale review July 10, 2025 15:46

The base branch was changed.

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 10, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 10, 2025
@socket-security
Copy link

socket-security bot commented Jul 10, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedclass-validator@​0.13.21002510080100
Added@​babel/​traverse@​7.22.1100257897100
Added@​types/​terser@​3.12.0671003575100
Added@​ast-grep/​napi-darwin-arm64@​0.3.31001003695100
Added@​ast-grep/​napi-darwin-x64@​0.3.3991003695100
Added@​ast-grep/​napi-linux-x64-gnu@​0.3.31001003695100
Added@​ast-grep/​napi-win32-arm64-msvc@​0.3.3991003695100
Added@​ast-grep/​napi-win32-ia32-msvc@​0.3.3991003695100
Added@​ast-grep/​napi-win32-x64-msvc@​0.3.31001003695100
Added@​swc/​counter@​0.1.31001003978100
Addednode-releases@​2.0.131001004179100
Addedfunction-bind@​1.1.2671008252100
Addedis-core-module@​2.12.1671008053100
Added@​swc/​plugin-jest@​1.5.117881005590100
Added@​babel/​plugin-transform-react-jsx-development@​7.18.61001005892100
Updatedjest-get-type@​25.2.6 ⏵ 29.6.310010060 +184100
Added@​babel/​plugin-syntax-async-generators@​7.8.41001006081100
Added@​babel/​plugin-syntax-import-meta@​7.10.41001006081100
Added@​babel/​plugin-syntax-json-strings@​7.8.31001006081100
Added@​babel/​plugin-syntax-logical-assignment-operators@​7.10.41001006081100
Added@​babel/​plugin-syntax-nullish-coalescing-operator@​7.8.31001006081100
Added@​babel/​plugin-syntax-numeric-separator@​7.10.41001006081100
Added@​babel/​plugin-syntax-object-rest-spread@​7.8.31001006081100
Added@​babel/​plugin-syntax-optional-catch-binding@​7.8.31001006081100
Added@​babel/​plugin-syntax-optional-chaining@​7.8.31001006081100
Added@​babel/​plugin-syntax-dynamic-import@​7.8.31001006081100
Added@​babel/​plugin-syntax-export-namespace-from@​7.8.31001006081100
Added@​babel/​plugin-syntax-private-property-in-object@​7.14.51001006081100
Added@​babel/​plugin-transform-dotall-regex@​7.18.61001006192100
Added@​babel/​plugin-transform-unicode-regex@​7.18.61001006192100
Added@​babel/​plugin-syntax-class-properties@​7.12.131001006181100
Added@​babel/​plugin-syntax-class-static-block@​7.14.51001006181100
Added@​babel/​plugin-syntax-top-level-await@​7.14.51001006181100
See 227 more rows in the dashboard

View full report

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 10, 2025
@socket-security
Copy link

socket-security bot commented Jul 10, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn Critical
class-validator@0.13.2 has a Critical CVE.

CVE: GHSA-fj58-h2fr-3pp2 SQL Injection and Cross-site Scripting in class-validator (CRITICAL)

Affected versions: < 0.14.0

Patched version: 0.14.0

From: package.jsonnpm/class-validator@0.13.2

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/class-validator@0.13.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
class-validator@0.13.2 has a Critical CVE.

CVE: GHSA-fj58-h2fr-3pp2 SQL Injection and Cross-site Scripting in class-validator (CRITICAL)

Affected versions: < 0.14.0

Patched version: 0.14.0

From: package.jsonnpm/class-validator@0.13.2

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/class-validator@0.13.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 10, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 10, 2025
@kdy1 kdy1 disabled auto-merge July 10, 2025 16:39
@kdy1 kdy1 merged commit 53f3881 into main Jul 10, 2025
168 checks passed
@kdy1 kdy1 deleted the kdy1/size branch July 10, 2025 16:40
@kdy1 kdy1 modified the milestones: Planned, v1.12.12 Jul 13, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants