Skip to content

Conversation

@mischnic
Copy link
Contributor

@mischnic mischnic commented Jun 5, 2025

This was the only place where Comments were queried for dummy spans (BytePos(0))

@mischnic mischnic requested a review from a team as a code owner June 5, 2025 07:57
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: e692980

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 5, 2025

CodSpeed Performance Report

Merging #10568 will create unknown performance changes

Comparing mischnic:mischnic/no-comments-for-dummy (ca1a9d5) with main (16e204d)

Summary

🆕 144 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 deserialization of serde N/A 2.5 µs N/A
🆕 serialization of serde N/A 2.9 µs N/A
🆕 css/visitor/compare/clone N/A 5 ms N/A
🆕 css/visitor/compare/fold_span N/A 6 ms N/A
🆕 css/visitor/compare/fold_span_panic N/A 6 ms N/A
🆕 css/visitor/compare/visit_mut_span N/A 5.4 ms N/A
🆕 css/visitor/compare/visit_mut_span_panic N/A 5.4 ms N/A
🆕 css/lexer/bootstrap_5_1_3 N/A 11.2 ms N/A
🆕 css/lexer/foundation_6_7_4 N/A 9.1 ms N/A
🆕 css/lexer/tailwind_3_1_1 N/A 1.8 ms N/A
🆕 css/parser/bootstrap_5_1_3 N/A 48.6 ms N/A
🆕 css/parser/foundation_6_7_4 N/A 38.4 ms N/A
🆕 css/parser/tailwind_3_1_1 N/A 7.5 ms N/A
🆕 es/codegen/colors N/A 70.8 µs N/A
🆕 es/codegen/large N/A 648.3 µs N/A
🆕 es/codegen/with-parser/colors N/A 182.9 µs N/A
🆕 es/codegen/with-parser/large N/A 1.4 ms N/A
🆕 es/lexer/angular N/A 12.7 ms N/A
🆕 es/lexer/backbone N/A 1.8 ms N/A
🆕 es/lexer/cal-com N/A 34.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@mischnic
Copy link
Contributor Author

mischnic commented Jun 5, 2025

Seems unrelated?

 Running tests/exec.rs (target/debug/deps/exec-5ccf6224773853ae) running 550 tests ➤ YN0000: Yarn detected that the current workflow is executed from a public pull request. For safety the hardened mode has been enabled. ➤ YN0000: It will prevent malicious lockfile manipulations, in exchange for a slower install time. You can opt-out if necessary; check our documentation for more details. ➤ YN0000: · Yarn 4.0.2 ➤ YN0000: ┌ Resolution step Resolution step ➤ YN0000: └ Completed in 6s 61ms ➤ YN0000: ┌ Post-resolution validation Post-resolution validation ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step Fetch step ➤ YN0000: └ Completed in 0s 484ms ➤ YN0000: ┌ Link step Link step ➤ YN0000: └ Completed in 0s 718ms ➤ YN0000: · Done with warnings in 7s 534ms node:internal/process/promises:391 triggerUncaughtException(err, true /* fromPromise */); ^ [Error: ENOENT: no such file or directory, open '/home/runner/work/swc/swc/packages/helpers/cjs/_create_for_of_iterator_helper_loose.cjs'] { errno: -2, code: 'ENOENT', syscall: 'open', path: '/home/runner/work/swc/swc/packages/helpers/cjs/_create_for_of_iterator_helper_loose.cjs' } Node.js v20.19.2 test run_babel_fixture_exec_test_tests__babel_exec__packages__babel_core__test__fixtures__transformation__misc__regression_7064__exec_js ... FAILED test run_babel_fixture_exec_test_tests__babel_exec__packages__babel_core__test__fixtures__transformation__regenerator__destructuring_parameters__exec_js ... FAILED test ru 
@kdy1 kdy1 added this to the Planned milestone Jun 5, 2025
@kdy1 kdy1 requested a review from a team as a code owner June 5, 2025 14:21
@kdy1 kdy1 changed the title Don't call cmt.get_leading for dummy span fix(es/codegen): Don't call cmt.get_leading for dummy span Jun 5, 2025
@kdy1 kdy1 merged commit 16e204d into swc-project:main Jun 5, 2025
18 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.12.0 Jun 10, 2025
@mischnic mischnic deleted the mischnic/no-comments-for-dummy branch June 26, 2025 14:38
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants