Skip to content

Conversation

@chenjiahan chenjiahan requested a review from a team as a code owner June 5, 2025 07:26
@chenjiahan
Copy link
Contributor Author

@kdy1 Could you release a new version of @swc/types after merging this? Thank you!

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 5, 2025

CodSpeed Performance Report

Merging #10567 will improve performances by 4.61%

Comparing chenjiahan:types_charset_0605 (4b95b97) with main (2b284e1)

Summary

⚡ 2 improvements
✅ 142 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 3 µs 2.9 µs +2.01%
es/lints/libs/terser 30.6 ms 29.3 ms +4.61%
Copy link
Contributor

@CodeMan62 CodeMan62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update type.rs file of binding_core_wasm and binding_minifier_wasm crates

@chenjiahan
Copy link
Contributor Author

Updated, thank you.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: 4b95b97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 self-assigned this Jun 5, 2025
@kdy1 kdy1 added this to the Planned milestone Jun 5, 2025
@kdy1 kdy1 merged commit 26b41e8 into swc-project:main Jun 5, 2025
169 checks passed
@kdy1
Copy link
Member

kdy1 commented Jun 5, 2025

@chenjiahan chenjiahan deleted the types_charset_0605 branch June 6, 2025 01:04
@chenjiahan
Copy link
Contributor Author

Thank you 🫶

@kdy1 kdy1 modified the milestones: Planned, v1.12.0 Jun 10, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants