perf(es/minifier): Use bigflags to reduce context size of analyzer (#10380)

Related #10379 Context: 16 bytes -> 8 bytes

Author: CPunisher

.changeset/five-jobs-teach.md

@@ -0,0 +1,7 @@
+---
+swc_ecma_minifier: minor
+swc_ecma_usage_analyzer: minor
+swc_core: minor
+---
+
+perf(es/usage_analyzer): Use bigflags to reduce context size

Cargo.lock

@@ -345,7 +345,7 @@ impl Storage for ProgramData {
  })
  });
 
- e.used_as_ref |= ctx.is_id_ref;
+ e.used_as_ref |= ctx.is_id_ref();
  e.ref_count += 1;
  e.usage_count += 1;
  // If it is inited in some child scope, but referenced in current scope
@@ -354,9 +354,9 @@ impl Storage for ProgramData {
  e.var_initialized = false;
  }
 
- e.inline_prevented |= ctx.inline_prevented;
- e.executed_multiple_time |= ctx.executed_multiple_time;
- e.used_in_cond |= ctx.in_cond;
+ e.inline_prevented |= ctx.inline_prevented();
+ e.executed_multiple_time |= ctx.executed_multiple_time();
+ e.used_in_cond |= ctx.in_cond();
  }
 
  fn report_assign(&mut self, ctx: Ctx, i: Id, is_op: bool, ty: Value<Type>) {
@@ -395,9 +395,9 @@ impl Storage for ProgramData {
  let curr = &to_visit[idx];
 
  if let Some(usage) = self.vars.get_mut(curr) {
- usage.inline_prevented |= ctx.inline_prevented;
- usage.executed_multiple_time |= ctx.executed_multiple_time;
- usage.used_in_cond |= ctx.in_cond;
+ usage.inline_prevented |= ctx.inline_prevented();
+ usage.executed_multiple_time |= ctx.executed_multiple_time();
+ usage.used_in_cond |= ctx.in_cond();
 
  if is_op {
  usage.usage_count += 1;
@@ -422,7 +422,7 @@ impl Storage for ProgramData {
  // }
 
  let v = self.vars.entry(i.to_id()).or_default();
- v.is_top_level |= ctx.is_top_level;
+ v.is_top_level |= ctx.is_top_level();
 
  // assigned or declared before this declaration
  if init_type.is_some() {
@@ -441,7 +441,8 @@ impl Storage for ProgramData {
  // This is not delcared yet, so this is the first declaration.
  if !v.declared {
  v.var_kind = kind;
- v.no_side_effect_for_member_access = ctx.in_decl_with_no_side_effect_for_member_access;
+ v.no_side_effect_for_member_access =
+ ctx.in_decl_with_no_side_effect_for_member_access();
  }
 
  if v.used_in_non_child_fn {
@@ -450,7 +451,7 @@ impl Storage for ProgramData {
 
  v.var_initialized |= init_type.is_some();
 
- if ctx.in_pat_of_param {
+ if ctx.in_pat_of_param() {
  v.merged_var_type = Some(Value::Unknown);
  } else {
  v.merged_var_type.merge(init_type);
@@ -462,7 +463,7 @@ impl Storage for ProgramData {
  if init_type.is_some() || kind.is_none() {
  self.initialized_vars.insert(i.to_id());
  }
- v.declared_as_catch_param |= ctx.in_catch_param;
+ v.declared_as_catch_param |= ctx.in_catch_param();
 
  v
  }

crates/swc_ecma_minifier/src/program_data.rs

@@ -23,6 +23,7 @@ trace-ast = []
 tracing-spans = []
 
 [dependencies]
+bitflags = { workspace = true }
 indexmap = { workspace = true }
 rustc-hash = { workspace = true }
 tracing = { workspace = true }

crates/swc_ecma_usage_analyzer/Cargo.toml

@@ -2,6 +2,7 @@
 
 use std::ops::{Deref, DerefMut};
 
+use bitflags::bitflags;
 use swc_ecma_ast::VarDeclKind;
 use swc_ecma_utils::{Type, Value};
 
@@ -25,26 +26,82 @@ where
 #[non_exhaustive]
 pub struct Ctx {
  pub var_decl_kind_of_pat: Option<VarDeclKind>,
+ pub in_pat_of_var_decl_with_init: Option<Value<Type>>,
+ pub(crate) bit_ctx: BitContext,
+}
 
- pub in_decl_with_no_side_effect_for_member_access: bool,
+impl Ctx {
+ #[inline]
+ pub(crate) fn with(mut self, flag: BitContext, value: bool) -> Self {
+ self.bit_ctx = self.bit_ctx.with(flag, value);
+ self
+ }
 
- pub in_pat_of_var_decl: bool,
- pub in_pat_of_var_decl_with_init: Option<Value<Type>>,
- pub in_pat_of_param: bool,
- pub in_catch_param: bool,
+ #[inline]
+ pub fn in_decl_with_no_side_effect_for_member_access(&self) -> bool {
+ self.bit_ctx
+ .contains(BitContext::InDeclWithNoSideEffectForMemberAccess)
+ }
 
- pub is_id_ref: bool,
+ #[inline]
+ pub fn in_pat_of_param(&self) -> bool {
+ self.bit_ctx.contains(BitContext::InPatOfParam)
+ }
 
- pub in_await_arg: bool,
+ #[inline]
+ pub fn in_catch_param(&self) -> bool {
+ self.bit_ctx.contains(BitContext::InCatchParam)
+ }
 
- pub in_left_of_for_loop: bool,
+ #[inline]
+ pub fn is_id_ref(&self) -> bool {
+ self.bit_ctx.contains(BitContext::IsIdRef)
+ }
 
- pub executed_multiple_time: bool,
- pub in_cond: bool,
+ #[inline]
+ pub fn inline_prevented(&self) -> bool {
+ self.bit_ctx.contains(BitContext::InlinePrevented)
+ }
 
- pub inline_prevented: bool,
+ #[inline]
+ pub fn in_cond(&self) -> bool {
+ self.bit_ctx.contains(BitContext::InCond)
+ }
 
- pub is_top_level: bool,
+ #[inline]
+ pub fn executed_multiple_time(&self) -> bool {
+ self.bit_ctx.contains(BitContext::ExecutedMultipleTime)
+ }
+
+ #[inline]
+ pub fn is_top_level(&self) -> bool {
+ self.bit_ctx.contains(BitContext::IsTopLevel)
+ }
+}
+
+bitflags! {
+ #[derive(Debug, Clone, Copy, Default)]
+ pub(crate) struct BitContext: u16 {
+ const InDeclWithNoSideEffectForMemberAccess = 1 << 0;
+ const InPatOfVarDecl = 1 << 1;
+ const InPatOfParam = 1 << 2;
+ const InCatchParam = 1 << 3;
+ const IsIdRef = 1 << 4;
+ const InAwaitArg = 1 << 5;
+ const InLeftOfForLoop = 1 << 6;
+ const ExecutedMultipleTime = 1 << 7;
+ const InCond = 1 << 8;
+ const InlinePrevented = 1 << 9;
+ const IsTopLevel = 1 << 10;
+ }
+}
+
+impl BitContext {
+ #[inline]
+ pub fn with(mut self, flag: Self, value: bool) -> Self {
+ self.set(flag, value);
+ self
+ }
 }
 
 pub(super) struct WithCtx<'a, S>